[GitHub] [accumulo] keith-turner commented on issue #1199: Fix #1122 Added concurrent structures to ThriftTransportPool

[GitBox <gi...@apache.org>]

keith-turner commented on issue #1199: Fix #1122 Added concurrent structures to ThriftTransportPool
URL: https://github.com/apache/accumulo/pull/1199#issuecomment-501860721
 
 
   @hkeebler it might be worthwhile to make some of these changes like  using `Map.merge` and `Map.computeIfAbsent` to the current code w/o making any other changes.
   
   As far as making this overall class non-blocking, that is up to you.  It may be easier to design a non-blocking pool from the ground up rather than trying to rewrite the existing code.  Could also research existing pooling libraries to see if any are highly concurrent.  I had also thought about using Guava cache in the past, but it was not a good fit because the cache is aMap and conceptually this pool is a multi-map.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services