You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/01 11:02:19 UTC
[GitHub] [tvm] bkmgit opened a new pull request, #13249: Add link to information on stable Rust release
bkmgit opened a new pull request, #13249:
URL: https://github.com/apache/tvm/pull/13249
Releases are frequent, so documenting the current release number is not helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] bkmgit commented on pull request #13249: [Docs][Rust] Add link to information on stable Rust release
Posted by GitBox <gi...@apache.org>.
bkmgit commented on PR #13249:
URL: https://github.com/apache/tvm/pull/13249#issuecomment-1328067738
Ok. Got an MSRV of 1.60
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] bkmgit closed pull request #13249: [Docs][Rust] Add link to information on stable Rust release
Posted by "bkmgit (via GitHub)" <gi...@apache.org>.
bkmgit closed pull request #13249: [Docs][Rust] Add link to information on stable Rust release
URL: https://github.com/apache/tvm/pull/13249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ehsanmok commented on pull request #13249: [Docs][Rust] Add link to information on stable Rust release
Posted by GitBox <gi...@apache.org>.
ehsanmok commented on PR #13249:
URL: https://github.com/apache/tvm/pull/13249#issuecomment-1301651997
MSRV rarely changes and there's no need for a template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ehsanmok commented on pull request #13249: [Docs][Rust] Add link to information on stable Rust release
Posted by GitBox <gi...@apache.org>.
ehsanmok commented on PR #13249:
URL: https://github.com/apache/tvm/pull/13249#issuecomment-1298956862
Thanks for your contribution! Unfortunately that's not sufficient. If want to change to stable, we need to provide the exact Minimum Supported Rust Version (MSRV). You can use [cargo-msrv](https://github.com/foresterre/cargo-msrv) for example, to compile and find the version and include it in the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] bkmgit commented on pull request #13249: Add link to information on stable Rust release
Posted by GitBox <gi...@apache.org>.
bkmgit commented on PR #13249:
URL: https://github.com/apache/tvm/pull/13249#issuecomment-1298358580
@jroesch Review would be appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] bkmgit commented on pull request #13249: [Docs][Rust] Add link to information on stable Rust release
Posted by GitBox <gi...@apache.org>.
bkmgit commented on PR #13249:
URL: https://github.com/apache/tvm/pull/13249#issuecomment-1328068811
@ehsanmok Let me know if anything else is needed. If not, can rebase and squash commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #13249: Add link to information on stable Rust release
Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13249:
URL: https://github.com/apache/tvm/pull/13249#issuecomment-1298356953
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* No users to auto-tag found, no teams are specified in PR title <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] bkmgit commented on pull request #13249: [Docs][Rust] Add link to information on stable Rust release
Posted by GitBox <gi...@apache.org>.
bkmgit commented on PR #13249:
URL: https://github.com/apache/tvm/pull/13249#issuecomment-1301636458
Thanks for your feedback. CI tests just stable https://github.com/apache/tvm/blob/main/docker/install/ubuntu_install_rust.sh . If MSVR is also required, maybe a CI test should also be added for this? It would probably also be helpful to automate regeneration of the README from a template whenever MSVR changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org