You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2016/06/01 17:52:28 UTC

Review Request 48138: GEODE-11 Adding stats for the lucene file system.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48138/
-----------------------------------------------------------

Review request for geode, Barry Oglesby, Jason Huynh, and xiaojian zhou.


Repository: geode


Description
-------

Adding stats to track changes to the lucene file system.

This adds the following stats:
readBytes
writtenBytes
fileCreates
temporaryFileCreates
fileDeletes
fileRenames

Also added a stat for totalHits to the LuceneIndexStats.


Diffs
-----

  geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java 8f2cb10a0dc2d930362473f575042ec25f04c7f2 
  geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexImpl.java 3b58a956857830a55f11fe11ac8a57adb3b53846 
  geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexStats.java dab1b0f65c1ff38cd0a2ed09f0a981e82c39552e 
  geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/PartitionedRepositoryManager.java 1b48316e9568f92ce02ca6fa34ebc90228736e63 
  geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/directory/RegionDirectory.java 28117bda74f10d8ec5c34707e935a31fadeca6a4 
  geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystem.java 5f5218a9050157836e72d64ab5d9d4c7eeeb3346 
  geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystemStats.java PRE-CREATION 
  geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImpl.java 47e43b54eda9ea185650922a2c41572bce5af059 
  geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexRecoveryHAIntegrationTest.java b4de0c53a5cb94380443b44b31d2fc23405e3933 
  geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexStatsJUnitTest.java 6633f22ea162ee18abfdde837970821178830a5b 
  geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/PartitionedRepositoryManagerJUnitTest.java f0ff7cae3f68fcdb1854e04d920e40818207088c 
  geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/directory/RegionDirectoryJUnitTest.java e8118c538e624e8857579345f5f314ee7c4a10ce 
  geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/DistributedScoringJUnitTest.java 4cc2d5cb5cd3682a119e91f64bb4c7a508b8e759 
  geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystemJUnitTest.java 78bf1de500269d06b6670174883bf268441e126d 
  geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystemStatsJUnitTest.java PRE-CREATION 
  geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImplJUnitTest.java f2a6bc44b0d19bb9df465c5df336cb5ff64d2e63 
  geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImplPerformanceTest.java 934998550420cdd900fc59a0dc0f87a80473b4af 

Diff: https://reviews.apache.org/r/48138/diff/


Testing
-------


Thanks,

Dan Smith

Re: Review Request 48138: GEODE-11 Adding stats for the lucene file system.

Posted by xiaojian zhou <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48138/#review135838
-----------------------------------------------------------


Ship it!




Ship It!

- xiaojian zhou


On June 1, 2016, 5:52 p.m., Dan Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48138/
> -----------------------------------------------------------
> 
> (Updated June 1, 2016, 5:52 p.m.)
> 
> 
> Review request for geode, Barry Oglesby, Jason Huynh, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Adding stats to track changes to the lucene file system.
> 
> This adds the following stats:
> readBytes
> writtenBytes
> fileCreates
> temporaryFileCreates
> fileDeletes
> fileRenames
> 
> Also added a stat for totalHits to the LuceneIndexStats.
> 
> 
> Diffs
> -----
> 
>   geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java 8f2cb10a0dc2d930362473f575042ec25f04c7f2 
>   geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexImpl.java 3b58a956857830a55f11fe11ac8a57adb3b53846 
>   geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexStats.java dab1b0f65c1ff38cd0a2ed09f0a981e82c39552e 
>   geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/PartitionedRepositoryManager.java 1b48316e9568f92ce02ca6fa34ebc90228736e63 
>   geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/directory/RegionDirectory.java 28117bda74f10d8ec5c34707e935a31fadeca6a4 
>   geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystem.java 5f5218a9050157836e72d64ab5d9d4c7eeeb3346 
>   geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystemStats.java PRE-CREATION 
>   geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImpl.java 47e43b54eda9ea185650922a2c41572bce5af059 
>   geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexRecoveryHAIntegrationTest.java b4de0c53a5cb94380443b44b31d2fc23405e3933 
>   geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexStatsJUnitTest.java 6633f22ea162ee18abfdde837970821178830a5b 
>   geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/PartitionedRepositoryManagerJUnitTest.java f0ff7cae3f68fcdb1854e04d920e40818207088c 
>   geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/directory/RegionDirectoryJUnitTest.java e8118c538e624e8857579345f5f314ee7c4a10ce 
>   geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/DistributedScoringJUnitTest.java 4cc2d5cb5cd3682a119e91f64bb4c7a508b8e759 
>   geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystemJUnitTest.java 78bf1de500269d06b6670174883bf268441e126d 
>   geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystemStatsJUnitTest.java PRE-CREATION 
>   geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImplJUnitTest.java f2a6bc44b0d19bb9df465c5df336cb5ff64d2e63 
>   geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImplPerformanceTest.java 934998550420cdd900fc59a0dc0f87a80473b4af 
> 
> Diff: https://reviews.apache.org/r/48138/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 48138: GEODE-11 Adding stats for the lucene file system.

Posted by Dan Smith <ds...@pivotal.io>.

> On June 1, 2016, 6:27 p.m., Jason Huynh wrote:
> > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexImpl.java, line 71
> > <https://reviews.apache.org/r/48138/diff/1/?file=1403386#file1403386line71>
> >
> >     Should these be passed in or be created in an overrideable method?  Do we plan on having different stats/stat types for pr and replicated region in the future?

Hmm, not yet, but I could see it happening the near future. I'll hoist these up into LuceneIndexForPartitionedRegion.


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48138/#review135834
-----------------------------------------------------------


On June 1, 2016, 5:52 p.m., Dan Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48138/
> -----------------------------------------------------------
> 
> (Updated June 1, 2016, 5:52 p.m.)
> 
> 
> Review request for geode, Barry Oglesby, Jason Huynh, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Adding stats to track changes to the lucene file system.
> 
> This adds the following stats:
> readBytes
> writtenBytes
> fileCreates
> temporaryFileCreates
> fileDeletes
> fileRenames
> 
> Also added a stat for totalHits to the LuceneIndexStats.
> 
> 
> Diffs
> -----
> 
>   geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java 8f2cb10a0dc2d930362473f575042ec25f04c7f2 
>   geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexImpl.java 3b58a956857830a55f11fe11ac8a57adb3b53846 
>   geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexStats.java dab1b0f65c1ff38cd0a2ed09f0a981e82c39552e 
>   geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/PartitionedRepositoryManager.java 1b48316e9568f92ce02ca6fa34ebc90228736e63 
>   geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/directory/RegionDirectory.java 28117bda74f10d8ec5c34707e935a31fadeca6a4 
>   geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystem.java 5f5218a9050157836e72d64ab5d9d4c7eeeb3346 
>   geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystemStats.java PRE-CREATION 
>   geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImpl.java 47e43b54eda9ea185650922a2c41572bce5af059 
>   geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexRecoveryHAIntegrationTest.java b4de0c53a5cb94380443b44b31d2fc23405e3933 
>   geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexStatsJUnitTest.java 6633f22ea162ee18abfdde837970821178830a5b 
>   geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/PartitionedRepositoryManagerJUnitTest.java f0ff7cae3f68fcdb1854e04d920e40818207088c 
>   geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/directory/RegionDirectoryJUnitTest.java e8118c538e624e8857579345f5f314ee7c4a10ce 
>   geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/DistributedScoringJUnitTest.java 4cc2d5cb5cd3682a119e91f64bb4c7a508b8e759 
>   geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystemJUnitTest.java 78bf1de500269d06b6670174883bf268441e126d 
>   geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystemStatsJUnitTest.java PRE-CREATION 
>   geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImplJUnitTest.java f2a6bc44b0d19bb9df465c5df336cb5ff64d2e63 
>   geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImplPerformanceTest.java 934998550420cdd900fc59a0dc0f87a80473b4af 
> 
> Diff: https://reviews.apache.org/r/48138/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 48138: GEODE-11 Adding stats for the lucene file system.

Posted by Jason Huynh <hu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48138/#review135834
-----------------------------------------------------------


Fix it, then Ship it!





geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexImpl.java (line 71)
<https://reviews.apache.org/r/48138/#comment200872>

    Should these be passed in or be created in an overrideable method?  Do we plan on having different stats/stat types for pr and replicated region in the future?


- Jason Huynh


On June 1, 2016, 5:52 p.m., Dan Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48138/
> -----------------------------------------------------------
> 
> (Updated June 1, 2016, 5:52 p.m.)
> 
> 
> Review request for geode, Barry Oglesby, Jason Huynh, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Adding stats to track changes to the lucene file system.
> 
> This adds the following stats:
> readBytes
> writtenBytes
> fileCreates
> temporaryFileCreates
> fileDeletes
> fileRenames
> 
> Also added a stat for totalHits to the LuceneIndexStats.
> 
> 
> Diffs
> -----
> 
>   geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java 8f2cb10a0dc2d930362473f575042ec25f04c7f2 
>   geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexImpl.java 3b58a956857830a55f11fe11ac8a57adb3b53846 
>   geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexStats.java dab1b0f65c1ff38cd0a2ed09f0a981e82c39552e 
>   geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/PartitionedRepositoryManager.java 1b48316e9568f92ce02ca6fa34ebc90228736e63 
>   geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/directory/RegionDirectory.java 28117bda74f10d8ec5c34707e935a31fadeca6a4 
>   geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystem.java 5f5218a9050157836e72d64ab5d9d4c7eeeb3346 
>   geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystemStats.java PRE-CREATION 
>   geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImpl.java 47e43b54eda9ea185650922a2c41572bce5af059 
>   geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexRecoveryHAIntegrationTest.java b4de0c53a5cb94380443b44b31d2fc23405e3933 
>   geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexStatsJUnitTest.java 6633f22ea162ee18abfdde837970821178830a5b 
>   geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/PartitionedRepositoryManagerJUnitTest.java f0ff7cae3f68fcdb1854e04d920e40818207088c 
>   geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/directory/RegionDirectoryJUnitTest.java e8118c538e624e8857579345f5f314ee7c4a10ce 
>   geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/DistributedScoringJUnitTest.java 4cc2d5cb5cd3682a119e91f64bb4c7a508b8e759 
>   geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystemJUnitTest.java 78bf1de500269d06b6670174883bf268441e126d 
>   geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystemStatsJUnitTest.java PRE-CREATION 
>   geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImplJUnitTest.java f2a6bc44b0d19bb9df465c5df336cb5ff64d2e63 
>   geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImplPerformanceTest.java 934998550420cdd900fc59a0dc0f87a80473b4af 
> 
> Diff: https://reviews.apache.org/r/48138/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Smith
> 
>