You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2019/05/07 18:54:10 UTC

[GitHub] [samza] cameronlee314 commented on a change in pull request #996: SAMZA-2166: [Scala cleanup] Convert StorageConfig.scala to Java

cameronlee314 commented on a change in pull request #996:  SAMZA-2166: [Scala cleanup] Convert StorageConfig.scala to Java 
URL: https://github.com/apache/samza/pull/996#discussion_r281779563
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/config/StorageConfig.java
 ##########
 @@ -89,7 +98,7 @@ public String getChangelogStream(String storeName) {
     if (systemStreamRes != null) {
       systemStreamRes = StreamManager.createUniqueNameForBatch(systemStreamRes, this);
 
 Review comment:
   Are you concerned about the call to a method called "create"? `createUniqueNameForBatch` just looks up some configs; it doesn't actually have a side effect.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services