You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "boluor (via GitHub)" <gi...@apache.org> on 2026/05/19 15:59:01 UTC

[PR] [fix] correct recycler metric names in recycler doc [doris-website]

boluor opened a new pull request, #3695:
URL: https://github.com/apache/doris-website/pull/3695

   ## Summary
   
   The recycler doc (`compute-storage-decoupled/recycler.md`) referenced two metric names that do not exist in Doris:
   
   - `recycler_instance_last_recycle_duration` → `recycler_instance_last_round_recycle_duration` (missing `round`)
   - `recycler_instance_last_success_ts` → `recycler_instance_recycle_last_success_ts` (missing `recycle_`)
   
   Verified against the apache/doris cloud source `cloud/src/common/bvars.cpp` — the real bvars are `g_bvar_recycler_instance_last_round_recycle_duration` and `g_bvar_recycler_instance_recycle_last_success_ts`, exposed as metric names `recycler_instance_last_round_recycle_duration` and `recycler_instance_recycle_last_success_ts`.
   
   The wrong names appeared in three places: the FAQ section (findings #58/#59), the metrics table's variable-name column (`g_bvar_...`), and the version-3.x example column. All occurrences corrected across all EN and Chinese versions.
   
   ## Test plan
   
   - [x] Verified the correct names against `apache/doris` `cloud/src/common/bvars.cpp` (the wrong forms have zero matches in the source)
   - [x] Confirmed the metrics-table "Metrics name" column was already correct (`...last_round...`) and is unaffected
   - [x] Confirmed no wrong metric name remains


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix] correct recycler metric names in recycler doc [doris-website]

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #3695:
URL: https://github.com/apache/doris-website/pull/3695


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org