[jira] [Commented] (ACCUMULO-2131) while statement used as if statement

["Josh Elser (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ACCUMULO-2131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14488262#comment-14488262 ] 

Josh Elser commented on ACCUMULO-2131:
--------------------------------------

Uhh, what's going on here, [~ctubbsii]? Bob had submitted a patch already.

> while statement used as if statement
> ------------------------------------
>
>                 Key: ACCUMULO-2131
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2131
>             Project: Accumulo
>          Issue Type: Bug
>          Components: tserver
>            Reporter: Eric Newton
>            Assignee: Bob Thorman
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 1.7.0
>
>         Attachments: 0001-ACCUMULO-2131-Ensure-source-is-re-checked-for-being-.patch, ACCUMULO-2131.patch
>
>
> Going through PMD output, and this looks a little sketchy in SourceSwitchingIterator.java:
> {noformat}
>   private boolean switchSource() throws IOException {
>     while (!source.isCurrent()) {
>       source = source.getNewDataSource();
>       iter = source.iterator();
>       if (iflag != null)
>         ((InterruptibleIterator) iter).setInterruptFlag(iflag);
>       
>       return true;
>     }
>     
>     return false;
>   }
> {noformat}
> I'm wondering if that "while" should be "if"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)