You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Werner Punz (JIRA)" <de...@myfaces.apache.org> on 2009/04/01 11:41:13 UTC

[jira] Created: (MYFACES-2172) Attach a javascript concatentation and compression part of jsf.js

Attach a javascript concatentation and compression part of jsf.js
-----------------------------------------------------------------

                 Key: MYFACES-2172
                 URL: https://issues.apache.org/jira/browse/MYFACES-2172
             Project: MyFaces Core
          Issue Type: New Feature
          Components: JSR-314
         Environment: Maven
            Reporter: Werner Punz
            Priority: Minor


The spec only allows one jsf.js file for all jsf related javascript includes, we have to map all external and internal apis to this file via the maven build process and also compression has to be added to reduce the file size to the possible minimum.
The maven javascript plugin allows both mechanisms via its compress and compile directives,
we have to add this to our maven build process to be in line with the spec!


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (MYFACES-2172) Attach a javascript concatentation and compression part of jsf.js

Posted by "Werner Punz (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694507#action_12694507 ] 

Werner Punz edited comment on MYFACES-2172 at 4/1/09 9:25 AM:
--------------------------------------------------------------

Ok I have it up and running with the official maven plugin, however the plugin is sandbox stage and the configuration is hackish due to some bugs in the plugins. I will consult the mailinglist if our plugin is usable for our usecase, and which approach is preferrable. Unfortunately due to a total lack of documentation on our plugin I have not yet fully figured out how to use our plugin (an attempt basically ended in an internal NPE)

I would rather prefer to standardize on an official maven javascript plugin in the long run than to roll our own. I will consult the mailinglist regarding all this!


      was (Author: werpu):
    Ok the maven plugin only allows certain tasks in war files, and erros on jar targets. Now we have a javascript plugin in our build tools as well, lets check what they do... it makes more sense to reuse our tools anyway, if possible.

  
> Attach a javascript concatentation and compression part of jsf.js
> -----------------------------------------------------------------
>
>                 Key: MYFACES-2172
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2172
>             Project: MyFaces Core
>          Issue Type: New Feature
>          Components: JSR-314
>         Environment: Maven
>            Reporter: Werner Punz
>            Assignee: Werner Punz
>            Priority: Minor
>
> The spec only allows one jsf.js file for all jsf related javascript includes, we have to map all external and internal apis to this file via the maven build process and also compression has to be added to reduce the file size to the possible minimum.
> The maven javascript plugin allows both mechanisms via its compress and compile directives,
> we have to add this to our maven build process to be in line with the spec!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (MYFACES-2172) Attach a javascript concatentation and compression part of jsf.js

Posted by "Werner Punz (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/MYFACES-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Werner Punz reopened MYFACES-2172:
----------------------------------


There have to be added some minor adjustments, the compression plugin has changed some internal name for the YUI compressor and generally the compressor is way mor nitpicky regarding errors!



> Attach a javascript concatentation and compression part of jsf.js
> -----------------------------------------------------------------
>
>                 Key: MYFACES-2172
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2172
>             Project: MyFaces Core
>          Issue Type: New Feature
>          Components: JSR-314
>         Environment: Maven
>            Reporter: Werner Punz
>            Assignee: Werner Punz
>            Priority: Minor
>
> The spec only allows one jsf.js file for all jsf related javascript includes, we have to map all external and internal apis to this file via the maven build process and also compression has to be added to reduce the file size to the possible minimum.
> The maven javascript plugin allows both mechanisms via its compress and compile directives,
> we have to add this to our maven build process to be in line with the spec!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (MYFACES-2172) Attach a javascript concatentation and compression part of jsf.js

Posted by "Werner Punz (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/MYFACES-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Werner Punz reopened MYFACES-2172:
----------------------------------


Now it is time to enable the compression. What will be used for now is the official javascript maven plugin, and I will nail it down to a version which works for now, we can switch over later when the plugin comes out of the alpha state.


> Attach a javascript concatentation and compression part of jsf.js
> -----------------------------------------------------------------
>
>                 Key: MYFACES-2172
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2172
>             Project: MyFaces Core
>          Issue Type: New Feature
>          Components: JSR-314
>         Environment: Maven
>            Reporter: Werner Punz
>            Assignee: Werner Punz
>            Priority: Minor
>
> The spec only allows one jsf.js file for all jsf related javascript includes, we have to map all external and internal apis to this file via the maven build process and also compression has to be added to reduce the file size to the possible minimum.
> The maven javascript plugin allows both mechanisms via its compress and compile directives,
> we have to add this to our maven build process to be in line with the spec!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (MYFACES-2172) Attach a javascript concatentation and compression part of jsf.js

Posted by "Werner Punz (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/MYFACES-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Werner Punz reopened MYFACES-2172:
----------------------------------


We have to reopen it because the code structure has changed


> Attach a javascript concatentation and compression part of jsf.js
> -----------------------------------------------------------------
>
>                 Key: MYFACES-2172
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2172
>             Project: MyFaces Core
>          Issue Type: New Feature
>          Components: JSR-314
>         Environment: Maven
>            Reporter: Werner Punz
>            Assignee: Werner Punz
>            Priority: Minor
>
> The spec only allows one jsf.js file for all jsf related javascript includes, we have to map all external and internal apis to this file via the maven build process and also compression has to be added to reduce the file size to the possible minimum.
> The maven javascript plugin allows both mechanisms via its compress and compile directives,
> we have to add this to our maven build process to be in line with the spec!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (MYFACES-2172) Attach a javascript concatentation and compression part of jsf.js

Posted by "Werner Punz (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/MYFACES-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Werner Punz resolved MYFACES-2172.
----------------------------------

    Resolution: Fixed

issue has been resolved with the last commit everything works now again!


> Attach a javascript concatentation and compression part of jsf.js
> -----------------------------------------------------------------
>
>                 Key: MYFACES-2172
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2172
>             Project: MyFaces Core
>          Issue Type: New Feature
>          Components: JSR-314
>         Environment: Maven
>            Reporter: Werner Punz
>            Assignee: Werner Punz
>            Priority: Minor
>
> The spec only allows one jsf.js file for all jsf related javascript includes, we have to map all external and internal apis to this file via the maven build process and also compression has to be added to reduce the file size to the possible minimum.
> The maven javascript plugin allows both mechanisms via its compress and compile directives,
> we have to add this to our maven build process to be in line with the spec!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (MYFACES-2172) Attach a javascript concatentation and compression part of jsf.js

Posted by "Werner Punz (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/MYFACES-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Werner Punz resolved MYFACES-2172.
----------------------------------

    Resolution: Fixed

I am resolving this for now, the mechanism now has been added to the pom.xml but is still commented out because we do not need it yet,
in the long run it is unclear if we use our own plugin or the official one.
I need some help on our own one, I could not get it working!



> Attach a javascript concatentation and compression part of jsf.js
> -----------------------------------------------------------------
>
>                 Key: MYFACES-2172
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2172
>             Project: MyFaces Core
>          Issue Type: New Feature
>          Components: JSR-314
>         Environment: Maven
>            Reporter: Werner Punz
>            Assignee: Werner Punz
>            Priority: Minor
>
> The spec only allows one jsf.js file for all jsf related javascript includes, we have to map all external and internal apis to this file via the maven build process and also compression has to be added to reduce the file size to the possible minimum.
> The maven javascript plugin allows both mechanisms via its compress and compile directives,
> we have to add this to our maven build process to be in line with the spec!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (MYFACES-2172) Attach a javascript concatentation and compression part of jsf.js

Posted by "Werner Punz (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/MYFACES-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Werner Punz resolved MYFACES-2172.
----------------------------------

    Resolution: Fixed

file list is updated...


> Attach a javascript concatentation and compression part of jsf.js
> -----------------------------------------------------------------
>
>                 Key: MYFACES-2172
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2172
>             Project: MyFaces Core
>          Issue Type: New Feature
>          Components: JSR-314
>         Environment: Maven
>            Reporter: Werner Punz
>            Assignee: Werner Punz
>            Priority: Minor
>
> The spec only allows one jsf.js file for all jsf related javascript includes, we have to map all external and internal apis to this file via the maven build process and also compression has to be added to reduce the file size to the possible minimum.
> The maven javascript plugin allows both mechanisms via its compress and compile directives,
> we have to add this to our maven build process to be in line with the spec!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MYFACES-2172) Attach a javascript concatentation and compression part of jsf.js

Posted by "Werner Punz (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694489#action_12694489 ] 

Werner Punz commented on MYFACES-2172:
--------------------------------------

Ok as it seems the current alpha stage javascript maven plugin provides what we need regarding concatenation
and compresion. This however means we have to add the maven sandbox to the repository list.
Can anyone live with it?


> Attach a javascript concatentation and compression part of jsf.js
> -----------------------------------------------------------------
>
>                 Key: MYFACES-2172
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2172
>             Project: MyFaces Core
>          Issue Type: New Feature
>          Components: JSR-314
>         Environment: Maven
>            Reporter: Werner Punz
>            Assignee: Werner Punz
>            Priority: Minor
>
> The spec only allows one jsf.js file for all jsf related javascript includes, we have to map all external and internal apis to this file via the maven build process and also compression has to be added to reduce the file size to the possible minimum.
> The maven javascript plugin allows both mechanisms via its compress and compile directives,
> we have to add this to our maven build process to be in line with the spec!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (MYFACES-2172) Attach a javascript concatentation and compression part of jsf.js

Posted by "Werner Punz (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/MYFACES-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Werner Punz resolved MYFACES-2172.
----------------------------------

    Resolution: Fixed

no complaints so far so I am closing this, it seems to work sufficiently


> Attach a javascript concatentation and compression part of jsf.js
> -----------------------------------------------------------------
>
>                 Key: MYFACES-2172
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2172
>             Project: MyFaces Core
>          Issue Type: New Feature
>          Components: JSR-314
>         Environment: Maven
>            Reporter: Werner Punz
>            Assignee: Werner Punz
>            Priority: Minor
>
> The spec only allows one jsf.js file for all jsf related javascript includes, we have to map all external and internal apis to this file via the maven build process and also compression has to be added to reduce the file size to the possible minimum.
> The maven javascript plugin allows both mechanisms via its compress and compile directives,
> we have to add this to our maven build process to be in line with the spec!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MYFACES-2172) Attach a javascript concatentation and compression part of jsf.js

Posted by "Werner Punz (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694507#action_12694507 ] 

Werner Punz commented on MYFACES-2172:
--------------------------------------

Ok the maven plugin only allows certain tasks in war files, and erros on jar targets. Now we have a javascript plugin in our build tools as well, lets check what they do... it makes more sense to reuse our tools anyway, if possible.


> Attach a javascript concatentation and compression part of jsf.js
> -----------------------------------------------------------------
>
>                 Key: MYFACES-2172
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2172
>             Project: MyFaces Core
>          Issue Type: New Feature
>          Components: JSR-314
>         Environment: Maven
>            Reporter: Werner Punz
>            Assignee: Werner Punz
>            Priority: Minor
>
> The spec only allows one jsf.js file for all jsf related javascript includes, we have to map all external and internal apis to this file via the maven build process and also compression has to be added to reduce the file size to the possible minimum.
> The maven javascript plugin allows both mechanisms via its compress and compile directives,
> we have to add this to our maven build process to be in line with the spec!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.