You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cassandra.apache.org by Jonathan Haddad <jo...@jonhaddad.com> on 2017/05/04 17:17:50 UTC
Re: Guidelines on testing
+1
On Tue, Apr 25, 2017 at 2:21 AM Stefan Podkowinski <sp...@apache.org> wrote:
> I don't see any reasons not to make this part of our guidelines. The
> idea of having a list of what should be tested in each kind of test
> makes sense. I also like the examples how to improve tests dealing with
> global state.
>
> Some of the integration test cases, such as "dry
> start"/"restart"/"shutdown"/"upgrade", could use some further
> description and how-to examples. Are there any existing tests we can
> link for reference?
>
> We also already have a testing related page in our documentation:
> http://cassandra.apache.org/doc/latest/development/testing.html
> Not sure if it would make sense to merge or create an additional document.
>
>
> On 24.04.2017 18:13, Blake Eggleston wrote:
> > About a month ago, in the ‘Code quality, principles and rules’ thread,
> I’d proposed adding some testing standards to the project in lieu of
> revisiting the idea of removing singletons. The idea was that we could
> drive incremental improvement of the test coverage and testability
> situation that could be applied in day to day work. I’ve pushed a first
> draft to my repo here:
> >
> > https://github.com/bdeggleston/cassandra/blob/testing-doc/TESTING.md
> >
> > Please take a look and let me know what you think. With the blessing of
> the pmc, I’d like this, or something like it, to be adopted as the
> reference for contributors and reviewers when deciding if a contribution is
> properly tested.
> >
> > Blake
> >
>
Re: Guidelines on testing
Posted by Blake Eggleston <be...@apple.com>.
I haven't had any objections, so I've opened https://issues.apache.org/jira/browse/CASSANDRA-13497
On May 4, 2017 at 10:18:10 AM, Jonathan Haddad (jon@jonhaddad.com) wrote:
+1
On Tue, Apr 25, 2017 at 2:21 AM Stefan Podkowinski <sp...@apache.org> wrote:
> I don't see any reasons not to make this part of our guidelines. The
> idea of having a list of what should be tested in each kind of test
> makes sense. I also like the examples how to improve tests dealing with
> global state.
>
> Some of the integration test cases, such as "dry
> start"/"restart"/"shutdown"/"upgrade", could use some further
> description and how-to examples. Are there any existing tests we can
> link for reference?
>
> We also already have a testing related page in our documentation:
> http://cassandra.apache.org/doc/latest/development/testing.html
> Not sure if it would make sense to merge or create an additional document.
>
>
> On 24.04.2017 18:13, Blake Eggleston wrote:
> > About a month ago, in the ‘Code quality, principles and rules’ thread,
> I’d proposed adding some testing standards to the project in lieu of
> revisiting the idea of removing singletons. The idea was that we could
> drive incremental improvement of the test coverage and testability
> situation that could be applied in day to day work. I’ve pushed a first
> draft to my repo here:
> >
> > https://github.com/bdeggleston/cassandra/blob/testing-doc/TESTING.md
> >
> > Please take a look and let me know what you think. With the blessing of
> the pmc, I’d like this, or something like it, to be adopted as the
> reference for contributors and reviewers when deciding if a contribution is
> properly tested.
> >
> > Blake
> >
>