[GitHub] [spark] srowen commented on a change in pull request #24008: [SPARK-24783][SQL] spark.sql.shuffle.partitions=0 should throw exception

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #24008: [SPARK-24783][SQL] spark.sql.shuffle.partitions=0 should throw exception
URL: https://github.com/apache/spark/pull/24008#discussion_r263600085
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
 ##########
 @@ -277,6 +277,7 @@ object SQLConf {
       "Note: For structured streaming, this configuration cannot be changed between query " +
       "restarts from the same checkpoint location.")
     .intConf
+    .checkValue(_ > 0, "The value of spark.sql.shuffle.partitions must be positive")
 
 Review comment:
   In theory, yeah. I'm not sure if we check every int parameter to verify it can successfully accept an int; that seems like it's tested by tests of the conf framework. Checking for -1, sure.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org