You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by si...@apache.org on 2019/06/01 06:52:31 UTC
[lucene-solr] branch master updated (1ff7b29 -> b28de24)
This is an automated email from the ASF dual-hosted git repository.
simonw pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git.
from 1ff7b29 SOLR-13504: improve autoscaling syntax by adding a nodeset attribute (#691)
add 165d2d5 LUCENE-8813: Ensure we never apply deletes from a closed DWPTDeleteQueue
add fceee24 apply feedback
add 086088e more feedback
add d488156 Merge branch 'master' into LUCENE-8813
new b28de24 LUCENE-8813: Ensure we never apply deletes from a closed DWPTDeleteQueue (#688)
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../org/apache/lucene/index/DocumentsWriter.java | 28 +++---
.../lucene/index/DocumentsWriterDeleteQueue.java | 103 ++++++++++++++++-----
.../lucene/index/DocumentsWriterFlushQueue.java | 10 +-
.../index/TestDocumentsWriterDeleteQueue.java | 34 ++++++-
4 files changed, 136 insertions(+), 39 deletions(-)
[lucene-solr] 01/01: LUCENE-8813: Ensure we never apply deletes
from a closed DWPTDeleteQueue (#688)
Posted by si...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
simonw pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git
commit b28de243be3144312543fdd7d7bde94de1938478
Merge: 1ff7b29 d488156
Author: Simon Willnauer <si...@apache.org>
AuthorDate: Sat Jun 1 08:52:23 2019 +0200
LUCENE-8813: Ensure we never apply deletes from a closed DWPTDeleteQueue (#688)
Today we don't have a strong protection that we add and apply deletes / updates
on or from an already flushed delete queue. DWPTDeleteQueue instances are replaced
once we do a full flush in order to reopen an NRT reader or commit the IndexWriter.
In LUCENE-8813 we tripped an assert that used to protect us from such an situation
but it didn't take all corner cases from concurrent flushing into account. This change
adds a stronger protection and ensures that we neither apply a closed delete queue nor
add any updates or deletes to it.
This change also allows to speculatively freeze the global buffer that might return
null now if the queue has already been closed. This is now possible since we ensure that
we never see modifications to the queue after it's been closed and that happens right after
the last DWPT for the ongoing full flush is done flushing.
.../org/apache/lucene/index/DocumentsWriter.java | 28 +++---
.../lucene/index/DocumentsWriterDeleteQueue.java | 103 ++++++++++++++++-----
.../lucene/index/DocumentsWriterFlushQueue.java | 10 +-
.../index/TestDocumentsWriterDeleteQueue.java | 34 ++++++-
4 files changed, 136 insertions(+), 39 deletions(-)