You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by "zonghaishang (GitHub)" <gi...@apache.org> on 2020/03/17 10:09:15 UTC

[GitHub] [dubbo-go-hessian2] zonghaishang opened pull request #167: Fix hessian codec bugs

<!--  Thanks for sending a pull request! 
-->

**What this PR does**:

**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #

**Special notes for your reviewer**:

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note

```

[ Full content available at: https://github.com/apache/dubbo-go-hessian2/pull/167 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go-hessian2] wongoo commented on pull request #167: Fix hessian codec bugs

Posted by "wongoo (GitHub)" <gi...@apache.org>.

these lines can be extracted to a new func

[ Full content available at: https://github.com/apache/dubbo-go-hessian2/pull/167 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go-hessian2] wongoo commented on pull request #167: Fix hessian codec bugs

Posted by "wongoo (GitHub)" <gi...@apache.org>.

@zonghaishang  the pojo should be recovered at the end of the unit test

[ Full content available at: https://github.com/apache/dubbo-go-hessian2/pull/167 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go-hessian2] wongoo commented on issue #167: Fix hessian codec bugs

Posted by "wongoo (GitHub)" <gi...@apache.org>.

LGTM

[ Full content available at: https://github.com/apache/dubbo-go-hessian2/pull/167 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go-hessian2] fangyincheng commented on pull request #167: Fix hessian codec bugs

Posted by "fangyincheng (GitHub)" <gi...@apache.org>.

when it return `err`, the `err` should be returned.

[ Full content available at: https://github.com/apache/dubbo-go-hessian2/pull/167 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go-hessian2] wongoo commented on pull request #167: Fix hessian codec bugs

Posted by "wongoo (GitHub)" <gi...@apache.org>.

the pojo should be recovered at the end of the unit test

[ Full content available at: https://github.com/apache/dubbo-go-hessian2/pull/167 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org