[jira] [Commented] (MAPREDUCE-397) In JobInProgress, failed TIP should be added back to the non-running queue only if the tip has not failed.

["jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048409#comment-13048409 ] 

jiraposter@reviews.apache.org commented on MAPREDUCE-397:
---------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/887/
-----------------------------------------------------------

Review request for hadoop-mapreduce.


Summary
-------

In case of a task failure, the corresponding TIP is added back to the non-running list via failMap()/failReduce() api. This reentry should be done only for TIPs that have not failed. Reentry is useless for failed TIPs.

Change checks for tip.isFailed() before proceeding.


This addresses bug MAPREDUCE-397.
    http://issues.apache.org/jira/browse/MAPREDUCE-397


Diffs
-----

  src/java/org/apache/hadoop/mapred/JobInProgress.java 429d2b0 

Diff: https://reviews.apache.org/r/887/diff


Testing
-------


Thanks,

Harsh



> In JobInProgress, failed TIP should be added back to the non-running queue only if the tip has not failed.
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-397
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-397
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Amar Kamat
>            Assignee: Harsh J
>            Priority: Trivial
>
> In case of a task failure, the corresponding TIP is added back to the non-running list via {{failMap()/failReduce()}} api. This reentry should be done only for TIPs that have not failed. Reentry is useless for failed TIPs.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira