[GitHub] [shardingsphere] wgy8283335 commented on a change in pull request #11692: Add Oracle SQL - Update statement

[GitBox <gi...@apache.org>]

wgy8283335 commented on a change in pull request #11692:
URL: https://github.com/apache/shardingsphere/pull/11692#discussion_r684858982



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/segment/dml/assignment/AssignmentSegment.java
##########
@@ -36,5 +39,7 @@
     
     private final ColumnSegment column;
     
+    private List<ColumnSegment> columns = new LinkedList<>();

Review comment:
       What about combine column and columns.
   
   
   ```
   @RequiredArgsConstructor
   @Getter
   public final class AssignmentSegment implements SQLSegment {
       
       private final int startIndex;
       
       private final int stopIndex;
       
       private final List<ColumnSegment> columns;
       
       private final List<ExpressionSegment> values;
   }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org