[jira] [Commented] (NIFI-4743) Suppress Nulls for PutElasticsearchHttpRecord

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-4743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381958#comment-16381958 ] 

ASF GitHub Bot commented on NIFI-4743:
--------------------------------------

GitHub user MikeThomsen opened a pull request:

    https://github.com/apache/nifi/pull/2501

    NIFI-4743 Added configurable null suppression to PutElasticsearchHttp…

    …Record using a modified verison of a patch from Robert Bruno.
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MikeThomsen/nifi NIFI-4743

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2501.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2501
    
----
commit 374f9e3f47540aed9cfc955c7d86e215b70910f0
Author: Mike Thomsen <mi...@...>
Date:   2018-03-01T13:00:03Z

    NIFI-4743 Added configurable null suppression to PutElasticsearchHttpRecord using a modified verison of a patch from Robert Bruno.

----


> Suppress Nulls for PutElasticsearchHttpRecord
> ---------------------------------------------
>
>                 Key: NIFI-4743
>                 URL: https://issues.apache.org/jira/browse/NIFI-4743
>             Project: Apache NiFi
>          Issue Type: New Feature
>          Components: Extensions
>            Reporter: Robert Bruno
>            Assignee: Mike Thomsen
>            Priority: Minor
>         Attachments: NullSuppression.java, PutElasticsearchHttpRecord.java
>
>
> Would be useful for PutElasticsearchHttpRecord to allow you to suppress NULL values in the JSON that is inserted into ES much like the JsonRecordSetWriter allows you to do.  Perhaps PutElasticsearchHttpRecord could some how make use of JsonRecordSetWriter so it would inherit this functionality.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)