You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2021/05/20 16:08:08 UTC
[GitHub] [jena] Claudenw opened a new pull request #1006: Permissions v4 main
Claudenw opened a new pull request #1006:
URL: https://github.com/apache/jena/pull/1006
Code to differentiate between hard and soft read errors.
Changes to migrate to V4.
SecurityEvaluator change adding isHardReadError() method and changes to test cases to test it.
Change from V3 functionality in that by default isHardReadError() is false so that
* when a method returns a list and `read` permission is not granted, an empty list is returned.
* when a methods return boolean based on presence of triple and `read` permissions are not granted, `false` is returned.
Previously these states would throw a `ReadDeniedException`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1006: Permissions v4 main
Posted by GitBox <gi...@apache.org>.
afs commented on pull request #1006:
URL: https://github.com/apache/jena/pull/1006#issuecomment-846438315
@Claudenw : Is there a JIRA for this?
For each version, there is a URL for all tickets labeled as fixed for a release for people who want details of all changes.
For next release: https://s.apache.org/jena-4.1.0-jira (it works per and post release state)
If you want it on that list, could you please add a JIRA and ref the PR or main commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] Claudenw merged pull request #1006: JENA-2109: Permissions v4 main
Posted by GitBox <gi...@apache.org>.
Claudenw merged pull request #1006:
URL: https://github.com/apache/jena/pull/1006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1006: Permissions v4 main
Posted by GitBox <gi...@apache.org>.
afs commented on pull request #1006:
URL: https://github.com/apache/jena/pull/1006#issuecomment-845356646
Looks good - builds, which is the main thing.
maven javadoc:
```
[WARNING] /home/afs/Jena/jena-permissions/src/main/java/org/apache/jena/permissions/SecurityEvaluatorAssembler.java:62: warning - invalid usage of tag <
[WARNING] /home/afs/Jena/jena-permissions/src/main/java/org/apache/jena/permissions/SecurityEvaluatorAssembler.java:64: warning - invalid usage of tag <
```
(and looking the javadoc for SecurityEvaluatorAssembler, there seem to be other format issues?)
Some of the license headers have been reformatted at some point: e.g. `SecuredQueryEngine` has lost some spaces compared to `AssemblerConstants`, the latter is ideal. Both are acceptable.
and in Eclipse I get these warnings:
```
Javadoc: Parameter prefixMapping is not declared SecuredPrefixMappingTest.java /jena-permissions/src/test/java/org/apache/jena/permissions/graph line 46 Java Problem
Javadoc: Unexpected tag SecuredStatementTest.java /jena-permissions/src/test/java/org/apache/jena/permissions/model line 94 Java Problem
The import org.apache.jena.graph.Node is never used SecuredAltTest.java /jena-permissions/src/test/java/org/apache/jena/permissions/model line 27 Java Problem
The import org.apache.jena.graph.Triple is never used SecuredAltTest.java /jena-permissions/src/test/java/org/apache/jena/permissions/model line 28 Java Problem
The import org.apache.jena.permissions.model.impl.SecuredStatementIterator is never used SecuredResourceTest.java /jena-permissions/src/test/java/org/apache/jena/permissions/model line 35 Java Problem
The import org.apache.jena.permissions.SecurityEvaluator.Action is never used MockSecurityEvaluator.java /jena-permissions/src/test/java/org/apache/jena/permissions line 26 Java Problem
The import org.apache.jena.rdf.model.Container is never used SecuredBagTest.java /jena-permissions/src/test/java/org/apache/jena/permissions/model line 24 Java Problem
The import org.apache.jena.vocabulary.RDF is never used SecuredAltTest.java /jena-permissions/src/test/java/org/apache/jena/permissions/model line 44 Java Problem
The import org.junit.Assert.assertTrue is never used SecuredResourceTest.java /jena-permissions/src/test/java/org/apache/jena/permissions/model line 23 Java Problem
The import org.junit.Ignore is never used SecuredStatementTest.java /jena-permissions/src/test/java/org/apache/jena/permissions/model line 51 Java Problem
The method addLiteral(Resource, Property, Object) from the type ModelCon is deprecated SecuredModelTest.java /jena-permissions/src/test/java/org/apache/jena/permissions/model line 170 Java Problem
The method get() of type new Supplier<PrefixMapping>(){} should be tagged with @Override since it actually overrides a superinterface method MemGraphTest.java /jena-permissions/src/test/java/org/apache/jena/permissions/graph line 236 Java Problem
The type ResourceF is deprecated SecuredModelImpl.java /jena-permissions/src/main/java/org/apache/jena/permissions/model/impl line 74 Java Problem
The type ResourceF is deprecated SecuredSeqImpl.java /jena-permissions/src/main/java/org/apache/jena/permissions/model/impl line 38 Java Problem
The type ResourceF is deprecated SecuredStatementImpl.java /jena-permissions/src/main/java/org/apache/jena/permissions/model/impl line 41 Java Problem
Type safety: Unchecked cast from Object to List<RDFNode> SecuredRDFListTest.java /jena-permissions/src/test/java/org/apache/jena/permissions/model line 515 Java Problem
Type safety: Unchecked cast from Object to List<RDFNode> SecuredRDFListTest.java /jena-permissions/src/test/java/org/apache/jena/permissions/model line 521 Java Problem
Type safety: Unchecked cast from Object to List<RDFNode> SecuredRDFListTest.java /jena-permissions/src/test/java/org/apache/jena/permissions/model line 539 Java Problem
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org