You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/01/22 05:20:15 UTC
Review Request 17173: Updated master and contender to write znode(s) in the
new (labelled) format.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17173/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, Brenden Matthews, and Jiang Yan Xu.
Bugs: MESOS-903
https://issues.apache.org/jira/browse/MESOS-903
Repository: mesos-git
Description
-------
See summary.
This is part 3 of MESOS-903.
Diffs
-----
src/master/contender.hpp 2a7e7c4380dfe130dbdb925c94a27441e843ece9
src/master/contender.cpp 89e368bae0485b06c7ee1bc5eade49c2a2d19959
src/master/master.cpp 008033e24b329623a3bbe865699bf0b555c0606d
src/tests/master_contender_detector_tests.cpp 9cd576f21561a86588ee0ea8a8458a9371284d47
src/zookeeper/contender.cpp d8a5201cf79269d4bf419c6375eeabfbd914c672
Diff: https://reviews.apache.org/r/17173/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 17173: Updated master and contender to write znode(s) in
the new (labelled) format.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17173/#review32564
-----------------------------------------------------------
Ship it!
src/master/contender.cpp
<https://reviews.apache.org/r/17173/#comment61456>
Can we check the return value? Return Failure?
src/zookeeper/contender.hpp
<https://reviews.apache.org/r/17173/#comment61466>
Any reason not to make the label optional?
- Benjamin Hindman
On Jan. 22, 2014, 10:20 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17173/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2014, 10:20 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Brenden Matthews, and Jiang Yan Xu.
>
>
> Bugs: MESOS-903
> https://issues.apache.org/jira/browse/MESOS-903
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
> This is part 3 of MESOS-903.
>
>
> Diffs
> -----
>
> src/master/contender.hpp 2a7e7c4380dfe130dbdb925c94a27441e843ece9
> src/master/contender.cpp 89e368bae0485b06c7ee1bc5eade49c2a2d19959
> src/master/master.cpp 008033e24b329623a3bbe865699bf0b555c0606d
> src/tests/master_contender_detector_tests.cpp 9cd576f21561a86588ee0ea8a8458a9371284d47
> src/tests/zookeeper_tests.cpp 656afdeb763f38db329aaacee7eda7ff9966573b
> src/zookeeper/contender.hpp e526e2d614b43ef795e91c4ec6ddac68d705cb47
> src/zookeeper/contender.cpp d8a5201cf79269d4bf419c6375eeabfbd914c672
>
> Diff: https://reviews.apache.org/r/17173/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 17173: Updated master and contender to write znode(s) in
the new (labelled) format.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17173/
-----------------------------------------------------------
(Updated Jan. 22, 2014, 11:38 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Brenden Matthews, and Jiang Yan Xu.
Changes
-------
benh's. NNFR.
Bugs: MESOS-903
https://issues.apache.org/jira/browse/MESOS-903
Repository: mesos-git
Description
-------
See summary.
This is part 3 of MESOS-903.
Diffs (updated)
-----
src/master/contender.hpp 2a7e7c4380dfe130dbdb925c94a27441e843ece9
src/master/contender.cpp 89e368bae0485b06c7ee1bc5eade49c2a2d19959
src/master/master.cpp 008033e24b329623a3bbe865699bf0b555c0606d
src/tests/master_contender_detector_tests.cpp 9cd576f21561a86588ee0ea8a8458a9371284d47
src/tests/zookeeper_tests.cpp 656afdeb763f38db329aaacee7eda7ff9966573b
src/zookeeper/contender.hpp e526e2d614b43ef795e91c4ec6ddac68d705cb47
src/zookeeper/contender.cpp d8a5201cf79269d4bf419c6375eeabfbd914c672
Diff: https://reviews.apache.org/r/17173/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 17173: Updated master and contender to write znode(s) in
the new (labelled) format.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17173/
-----------------------------------------------------------
(Updated Jan. 22, 2014, 10:20 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Brenden Matthews, and Jiang Yan Xu.
Changes
-------
benh's.
Bugs: MESOS-903
https://issues.apache.org/jira/browse/MESOS-903
Repository: mesos-git
Description
-------
See summary.
This is part 3 of MESOS-903.
Diffs (updated)
-----
src/master/contender.hpp 2a7e7c4380dfe130dbdb925c94a27441e843ece9
src/master/contender.cpp 89e368bae0485b06c7ee1bc5eade49c2a2d19959
src/master/master.cpp 008033e24b329623a3bbe865699bf0b555c0606d
src/tests/master_contender_detector_tests.cpp 9cd576f21561a86588ee0ea8a8458a9371284d47
src/tests/zookeeper_tests.cpp 656afdeb763f38db329aaacee7eda7ff9966573b
src/zookeeper/contender.hpp e526e2d614b43ef795e91c4ec6ddac68d705cb47
src/zookeeper/contender.cpp d8a5201cf79269d4bf419c6375eeabfbd914c672
Diff: https://reviews.apache.org/r/17173/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 17173: Updated master and contender to write znode(s) in
the new (labelled) format.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17173/#review32506
-----------------------------------------------------------
src/master/contender.cpp
<https://reviews.apache.org/r/17173/#comment61366>
We should be controlling and injecting the label here, after this point the code underneath has no idea that this is/was a MasterInfo, so using something like 'info' for the label doesn't make sense.
src/zookeeper/contender.cpp
<https://reviews.apache.org/r/17173/#comment61367>
Did using Some(...) not work?
- Benjamin Hindman
On Jan. 22, 2014, 4:20 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17173/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2014, 4:20 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Brenden Matthews, and Jiang Yan Xu.
>
>
> Bugs: MESOS-903
> https://issues.apache.org/jira/browse/MESOS-903
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
> This is part 3 of MESOS-903.
>
>
> Diffs
> -----
>
> src/master/contender.hpp 2a7e7c4380dfe130dbdb925c94a27441e843ece9
> src/master/contender.cpp 89e368bae0485b06c7ee1bc5eade49c2a2d19959
> src/master/master.cpp 008033e24b329623a3bbe865699bf0b555c0606d
> src/tests/master_contender_detector_tests.cpp 9cd576f21561a86588ee0ea8a8458a9371284d47
> src/zookeeper/contender.cpp d8a5201cf79269d4bf419c6375eeabfbd914c672
>
> Diff: https://reviews.apache.org/r/17173/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>