You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Juanjo Marron <jm...@us.ibm.com> on 2016/03/24 01:22:20 UTC
Review Request 45254: Apply the stack featurization prototype
detailed on AMBARI-13364 to TEZ service
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45254/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
Bugs: AMBARI-15137
https://issues.apache.org/jira/browse/AMBARI-15137
Repository: ambari
Description
-------
Apply the stack featurization prototype detailed on AMBARI-13364 to TEZ service
Diffs
-----
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 0165c0b
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/pre_upgrade.py 1faedf9
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py c0c66af
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py e770d9b
Diff: https://reviews.apache.org/r/45254/diff/
Testing
-------
TEZ fresh installation
Thanks,
Juanjo Marron
Re: Review Request 45254: Apply the stack featurization prototype
detailed on AMBARI-13364 to TEZ service
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45254/#review125190
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py (line 54)
<https://reviews.apache.org/r/45254/#comment187981>
Can you also remove HDP hardcoding here.
- Jayush Luniya
On March 24, 2016, 12:22 a.m., Juanjo Marron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45254/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 12:22 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
>
>
> Bugs: AMBARI-15137
> https://issues.apache.org/jira/browse/AMBARI-15137
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Apply the stack featurization prototype detailed on AMBARI-13364 to TEZ service
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 0165c0b
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/pre_upgrade.py 1faedf9
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py c0c66af
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py e770d9b
>
> Diff: https://reviews.apache.org/r/45254/diff/
>
>
> Testing
> -------
>
> TEZ fresh installation
>
>
> Thanks,
>
> Juanjo Marron
>
>
Re: Review Request 45254: Apply the stack featurization prototype
detailed on AMBARI-13364 to TEZ service
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45254/#review125189
-----------------------------------------------------------
Ship it!
Will commit after AMBARI-15525 is committed.
- Jayush Luniya
On March 24, 2016, 12:22 a.m., Juanjo Marron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45254/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 12:22 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
>
>
> Bugs: AMBARI-15137
> https://issues.apache.org/jira/browse/AMBARI-15137
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Apply the stack featurization prototype detailed on AMBARI-13364 to TEZ service
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 0165c0b
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/pre_upgrade.py 1faedf9
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py c0c66af
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py e770d9b
>
> Diff: https://reviews.apache.org/r/45254/diff/
>
>
> Testing
> -------
>
> TEZ fresh installation
>
>
> Thanks,
>
> Juanjo Marron
>
>
Re: Review Request 45254: Apply the stack featurization prototype
detailed on AMBARI-13364 to TEZ service
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45254/#review125187
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py (line 60)
<https://reviews.apache.org/r/45254/#comment187978>
FYI, you will need the fix in stack_features.py in https://reviews.apache.org/r/45261 for this to work
- Jayush Luniya
On March 24, 2016, 12:22 a.m., Juanjo Marron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45254/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 12:22 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
>
>
> Bugs: AMBARI-15137
> https://issues.apache.org/jira/browse/AMBARI-15137
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Apply the stack featurization prototype detailed on AMBARI-13364 to TEZ service
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 0165c0b
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/pre_upgrade.py 1faedf9
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py c0c66af
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py e770d9b
>
> Diff: https://reviews.apache.org/r/45254/diff/
>
>
> Testing
> -------
>
> TEZ fresh installation
>
>
> Thanks,
>
> Juanjo Marron
>
>
Re: Review Request 45254: Apply the stack featurization prototype
detailed on AMBARI-13364 to TEZ service
Posted by Juanjo Marron <jm...@us.ibm.com>.
> On March 24, 2016, 6:59 p.m., Jayush Luniya wrote:
> > Ship It!
>
> Jayush Luniya wrote:
> Committed to trunk
Thanks for the review and for commiting!
- Juanjo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45254/#review125316
-----------------------------------------------------------
On March 24, 2016, 6:22 p.m., Juanjo Marron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45254/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 6:22 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
>
>
> Bugs: AMBARI-15137
> https://issues.apache.org/jira/browse/AMBARI-15137
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Apply the stack featurization prototype detailed on AMBARI-13364 to TEZ service
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 0165c0b
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/pre_upgrade.py 1faedf9
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py c0c66af
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py e770d9b
>
> Diff: https://reviews.apache.org/r/45254/diff/
>
>
> Testing
> -------
>
> TEZ fresh installation
>
>
> Thanks,
>
> Juanjo Marron
>
>
Re: Review Request 45254: Apply the stack featurization prototype
detailed on AMBARI-13364 to TEZ service
Posted by Jayush Luniya <jl...@hortonworks.com>.
> On March 24, 2016, 6:59 p.m., Jayush Luniya wrote:
> > Ship It!
Committed to trunk
- Jayush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45254/#review125316
-----------------------------------------------------------
On March 24, 2016, 6:22 p.m., Juanjo Marron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45254/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 6:22 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
>
>
> Bugs: AMBARI-15137
> https://issues.apache.org/jira/browse/AMBARI-15137
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Apply the stack featurization prototype detailed on AMBARI-13364 to TEZ service
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 0165c0b
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/pre_upgrade.py 1faedf9
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py c0c66af
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py e770d9b
>
> Diff: https://reviews.apache.org/r/45254/diff/
>
>
> Testing
> -------
>
> TEZ fresh installation
>
>
> Thanks,
>
> Juanjo Marron
>
>
Re: Review Request 45254: Apply the stack featurization prototype
detailed on AMBARI-13364 to TEZ service
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45254/#review125316
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On March 24, 2016, 6:22 p.m., Juanjo Marron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45254/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 6:22 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
>
>
> Bugs: AMBARI-15137
> https://issues.apache.org/jira/browse/AMBARI-15137
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Apply the stack featurization prototype detailed on AMBARI-13364 to TEZ service
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 0165c0b
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/pre_upgrade.py 1faedf9
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py c0c66af
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py e770d9b
>
> Diff: https://reviews.apache.org/r/45254/diff/
>
>
> Testing
> -------
>
> TEZ fresh installation
>
>
> Thanks,
>
> Juanjo Marron
>
>
Re: Review Request 45254: Apply the stack featurization prototype
detailed on AMBARI-13364 to TEZ service
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45254/#review125314
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On March 24, 2016, 6:22 p.m., Juanjo Marron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45254/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 6:22 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
>
>
> Bugs: AMBARI-15137
> https://issues.apache.org/jira/browse/AMBARI-15137
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Apply the stack featurization prototype detailed on AMBARI-13364 to TEZ service
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 0165c0b
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/pre_upgrade.py 1faedf9
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py c0c66af
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py e770d9b
>
> Diff: https://reviews.apache.org/r/45254/diff/
>
>
> Testing
> -------
>
> TEZ fresh installation
>
>
> Thanks,
>
> Juanjo Marron
>
>
Re: Review Request 45254: Apply the stack featurization prototype
detailed on AMBARI-13364 to TEZ service
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45254/#review125326
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On March 24, 2016, 6:22 p.m., Juanjo Marron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45254/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 6:22 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
>
>
> Bugs: AMBARI-15137
> https://issues.apache.org/jira/browse/AMBARI-15137
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Apply the stack featurization prototype detailed on AMBARI-13364 to TEZ service
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 0165c0b
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/pre_upgrade.py 1faedf9
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py c0c66af
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py e770d9b
>
> Diff: https://reviews.apache.org/r/45254/diff/
>
>
> Testing
> -------
>
> TEZ fresh installation
>
>
> Thanks,
>
> Juanjo Marron
>
>
Re: Review Request 45254: Apply the stack featurization prototype
detailed on AMBARI-13364 to TEZ service
Posted by Juanjo Marron <jm...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45254/
-----------------------------------------------------------
(Updated March 24, 2016, 6:22 p.m.)
Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
Changes
-------
Solved last review comments:
- parameterize get_stack_to_component()
- Remove unused imports
Bugs: AMBARI-15137
https://issues.apache.org/jira/browse/AMBARI-15137
Repository: ambari
Description
-------
Apply the stack featurization prototype detailed on AMBARI-13364 to TEZ service
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 0165c0b
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/pre_upgrade.py 1faedf9
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py c0c66af
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py e770d9b
Diff: https://reviews.apache.org/r/45254/diff/
Testing
-------
TEZ fresh installation
Thanks,
Juanjo Marron
Re: Review Request 45254: Apply the stack featurization prototype
detailed on AMBARI-13364 to TEZ service
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45254/#review125191
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/pre_upgrade.py (line 25)
<https://reviews.apache.org/r/45254/#comment187983>
Remove unused compare_versions import
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py (line 28)
<https://reviews.apache.org/r/45254/#comment187982>
Remove unused compare_versions import
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py (line 36)
<https://reviews.apache.org/r/45254/#comment187984>
Remove unused compare_versions import
- Jayush Luniya
On March 24, 2016, 12:22 a.m., Juanjo Marron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45254/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 12:22 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
>
>
> Bugs: AMBARI-15137
> https://issues.apache.org/jira/browse/AMBARI-15137
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Apply the stack featurization prototype detailed on AMBARI-13364 to TEZ service
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 0165c0b
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/pre_upgrade.py 1faedf9
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py c0c66af
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py e770d9b
>
> Diff: https://reviews.apache.org/r/45254/diff/
>
>
> Testing
> -------
>
> TEZ fresh installation
>
>
> Thanks,
>
> Juanjo Marron
>
>