You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ofbiz.apache.org by "Jacques Le Roux (JIRA)" <ji...@apache.org> on 2019/01/08 10:59:00 UTC

[jira] [Closed] (OFBIZ-10773) The ‘ModelFieldType’ class members should be private.

     [ https://issues.apache.org/jira/browse/OFBIZ-10773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-10773.
-----------------------------------
    Resolution: Fixed

Thanks Mathieu,

Your patch is in trunk at revision: 1850728  

I checked, all these members are only used in the class and the default public constructor is useless (it would be automatically added by the compiler if there was no other constructors, and there is one: http://tutorials.jenkov.com/java/constructors.html#default-no-arg-constructors)

> The ‘ModelFieldType’ class members should be private.
> -----------------------------------------------------
>
>                 Key: OFBIZ-10773
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10773
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Mathieu Lirzin
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-10773_Make-the-ModelFieldType-class-member-private-and-rem.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)