You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by Oleg Kalnichevski <ol...@apache.org> on 2008/06/15 16:42:49 UTC
Re: svn commit: r667954
On Sun, 2008-06-15 at 15:31 +0100, sebb wrote:
> On 15/06/2008, olegk@apache.org <ol...@apache.org> wrote:
> > Author: olegk
> > Date: Sun Jun 15 05:50:39 2008
> > New Revision: 667954
> >
> > URL: http://svn.apache.org/viewvc?rev=667954&view=rev
> > Log:
> > HTTPCORE-163: Fixed AbstractMultiworkerIOReactor#execute() to correctly propagate the original I/O exception in case of an abnormal termination.
> > Contributed by Patrick Moore <patmoore at ieee.org>
> > Reviewed by Oleg Kalnichevski
> >
...
> >
> > @@ -155,6 +156,7 @@
> > }
> >
> > if (this.status.compareTo(IOReactorStatus.ACTIVE) > 0) {
> > + completed = true;
> > break;
> > }
> > processEvents(readyCount);
> > @@ -180,11 +182,12 @@
> >
> > } catch (ClosedSelectorException ex) {
>
> The exception is still ignored - or am I missing something here?
>
> I think there should at least be a comment to say why it can be ignored.
>
I think it is ok to ignore this exception. It is thrown when an
operation is attempted on a closed selector, which means the i/o reactor
is in the process of being shut down.
I'll add a comment to that effect.
Oleg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: svn commit: r667954
Posted by sebb <se...@gmail.com>.
On 15/06/2008, Oleg Kalnichevski <ol...@apache.org> wrote:
> On Sun, 2008-06-15 at 15:31 +0100, sebb wrote:
> > On 15/06/2008, olegk@apache.org <ol...@apache.org> wrote:
> > > Author: olegk
> > > Date: Sun Jun 15 05:50:39 2008
> > > New Revision: 667954
> > >
> > > URL: http://svn.apache.org/viewvc?rev=667954&view=rev
> > > Log:
> > > HTTPCORE-163: Fixed AbstractMultiworkerIOReactor#execute() to correctly propagate the original I/O exception in case of an abnormal termination.
> > > Contributed by Patrick Moore <patmoore at ieee.org>
> > > Reviewed by Oleg Kalnichevski
> > >
>
> ...
>
> > >
> > > @@ -155,6 +156,7 @@
> > > }
> > >
> > > if (this.status.compareTo(IOReactorStatus.ACTIVE) > 0) {
> > > + completed = true;
> > > break;
> > > }
> > > processEvents(readyCount);
> > > @@ -180,11 +182,12 @@
> > >
> > > } catch (ClosedSelectorException ex) {
> >
> > The exception is still ignored - or am I missing something here?
> >
> > I think there should at least be a comment to say why it can be ignored.
> >
>
> I think it is ok to ignore this exception. It is thrown when an
> operation is attempted on a closed selector, which means the i/o reactor
> is in the process of being shut down.
>
> I'll add a comment to that effect.
>
OK, thanks.
The JIRA issue mentioned an ignored exception so I was surprised when
it was still ignored after the patch was applied...
Also, ignored exceptions tend to trigger bug warnings, so having a
comment will help in future.
> Oleg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org