You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/11 10:51:18 UTC
[GitHub] [spark] zhengruifeng commented on a diff in pull request #38130: [SPARK-40556][PS][SQL] AQE clean up resources after each stage and eagerly clean Pandas Index Cache
zhengruifeng commented on code in PR #38130:
URL: https://github.com/apache/spark/pull/38130#discussion_r992162591
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/python/AttachDistributedSequenceExec.scala:
##########
@@ -63,6 +97,16 @@ case class AttachDistributedSequenceExec(
}
}
+ override protected[sql] def cleanupResources(): Unit = {
+ this.synchronized {
+ if (cached != null && cached.getStorageLevel != StorageLevel.NONE) {
Review Comment:
I think so, maybe we don't need the `synchronized `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org