[GitHub] [airflow] Trollgeir edited a comment on issue #5319: [AIRFLOW-4564] Azure Container Instance improvements

[GitBox <gi...@apache.org>]

Trollgeir edited a comment on issue #5319: [AIRFLOW-4564] Azure Container Instance improvements
URL: https://github.com/apache/airflow/pull/5319#issuecomment-496739095
 
 
   > @Trollgeir There is a failing test:
   > 
   > ```
   > ======================================================================
   > 7) ERROR: test_get_state_exitcode_details (tests.contrib.hooks.test_azure_container_instance_hook.TestAzureContainerInstanceHook)
   > ----------------------------------------------------------------------
   >    Traceback (most recent call last):
   >     /usr/lib/python3.5/unittest/mock.py line 1157 in patched
   >       return func(*args, **keywargs)
   >     tests/contrib/hooks/test_azure_container_instance_hook.py line 76 in test_get_state_exitcode_details
   >       state, exit_code, details = self.testHook.get_state_exitcode_details('resource-group', 'test')
   >     airflow/contrib/hooks/azure_container_instance_hook.py line 109 in get_state_exitcode_details
   >       raw=False)
   >     .tox/py35-backend_sqlite-env_docker/lib/python3.5/site-packages/azure/mgmt/containerinstance/operations/container_groups_operations.py line 232 in get
   >       request = self._client.get(url, query_parameters, header_parameters)
   >    TypeError: get() takes from 1 to 3 positional arguments but 4 were given
   > ```
   
   This is due to an older version of `msrest`. Upgrading to `msrest 0.6.6` fixes this problem.
   
   Furthermore this will cause: 
   
   > ERROR: azure-datalake-store 0.0.19 has requirement `msrest~=0.4.5`, but you'll have `msrest 0.6.6` which is incompatible.
   
   `azure-datalake-store` is also compatible once upgraded to version 0.0.44, which I reckon we should? Otherwise I could try to work around the problem.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services