[GitHub] [solr] thelabdude commented on pull request #219: SOLR-15525: Allow Zookeeper ACL credentials to be passed via env vars instead of Java system properties

[GitBox <gi...@apache.org>]

thelabdude commented on pull request #219:
URL: https://github.com/apache/solr/pull/219#issuecomment-879921695


   > Just reading this, are we adding "YAWTCS": _Yet Another Way To Configure Solr? I wonder if it's worth taking a pass through Solr and figuring out how to use this same pattern across all our various system properties? For example, today we support `-Dsolr.auth.jwt.allowOutboundHttp=true`. Could we extend this pattern to allow `-Dsolr.auth.jwt.allowOutboundHttp=env:SOME_ENV_VAR`? Or is this a situation that ONLY would every apply to Zookeeper ACL and wouldn't make sense elsewhere.
   
   I think only sensitive properties like credentials need this pattern as the main problem here is exposing credentials in Java sys props


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org