You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Shahaf <d....@daniel.shahaf.name> on 2012/05/11 15:09:14 UTC

compiler warnings buildbot?

Idea: add a buildbot slave that turns red whenever a compiler warning
(such as "unused variable" or or "non-C89 comments") is introduced.

Justification: we treat new compiler warnings as bugs, and point them
out and fix them when they are introduced; this just makes them easier
to spot.

Proposed implementation:
% apt-get build-dep subversion; install serf 1.0.x@HEAD
% ./autogen.sh
% './configure'  '--enable-maintainer-mode' '-C' 'CFLAGS=
-DSVN_UNALIGNED_ACCESS_IS_OK=0 -DSUFFIX_LINES_TO_KEEP=0
-DSVN_DEPRECATED= -Wformat=0 -Wno-unreachable-code -g
-Werror' 'CC=x86_64-linux-gnu-gcc' '--with-serf=/usr/local'
'--prefix=/usr/local/nonexistent'
% make && return "green" || return "red"

When I rebuild HEAD cleanly as above, I get only four warnings, all of
which were introduced recently.

A more sophisticated implementation might parse make's stderr and use
some smarter logic to decide what errors to ignore; the above only
checks for "No warnings other than 'Unreachable code' and 'Format
string' anywhere in the code".

Thoughts?

Daniel