You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tika.apache.org by "Andrew Jackson (JIRA)" <ji...@apache.org> on 2012/04/23 16:03:33 UTC
[jira] [Created] (TIKA-900) Tika fails to detect ISO9660 disk
images
Andrew Jackson created TIKA-900:
-----------------------------------
Summary: Tika fails to detect ISO9660 disk images
Key: TIKA-900
URL: https://issues.apache.org/jira/browse/TIKA-900
Project: Tika
Issue Type: Bug
Components: mime
Affects Versions: 1.1
Environment: Any.
Reporter: Andrew Jackson
Priority: Minor
I have been testing Tika's ability to identify ISO9660 disk image file systems, and discovered two problems. Firstly, the offset match matcher was wrong (37633 instead of 37633). Secondly, and more seriously, it was impossible for that signaure to ever match, because the default buffer size was far to small. It is currently set to 8KB, and as this signature is some 36KB into the file, Tika could never find the match. The attached patch fixes the magic, and extends the buffer to 64KB.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TIKA-900) Tika fails to detect ISO9660 disk
images
Posted by "Andrew Jackson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TIKA-900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Jackson updated TIKA-900:
--------------------------------
Description: I have been testing Tika's ability to identify ISO9660 disk image file systems, and discovered two problems. Firstly, the offset match matcher was wrong (37633 instead of 32769). Secondly, and more seriously, it was impossible for that signaure to ever match, because the default buffer size was far too small. It is currently set to 8KB, and as this signature is some 36KB into the file, Tika could never find the match. The attached patch fixes the magic, and extends the buffer to 64KB. (was: I have been testing Tika's ability to identify ISO9660 disk image file systems, and discovered two problems. Firstly, the offset match matcher was wrong (37633 instead of 32769). Secondly, and more seriously, it was impossible for that signaure to ever match, because the default buffer size was far to small. It is currently set to 8KB, and as this signature is some 36KB into the file, Tika could never find the match. The attached patch fixes the magic, and extends the buffer to 64KB.)
> Tika fails to detect ISO9660 disk images
> ----------------------------------------
>
> Key: TIKA-900
> URL: https://issues.apache.org/jira/browse/TIKA-900
> Project: Tika
> Issue Type: Bug
> Components: mime
> Affects Versions: 1.1
> Environment: Any.
> Reporter: Andrew Jackson
> Priority: Minor
> Attachments: iso-image-detection.patch
>
>
> I have been testing Tika's ability to identify ISO9660 disk image file systems, and discovered two problems. Firstly, the offset match matcher was wrong (37633 instead of 32769). Secondly, and more seriously, it was impossible for that signaure to ever match, because the default buffer size was far too small. It is currently set to 8KB, and as this signature is some 36KB into the file, Tika could never find the match. The attached patch fixes the magic, and extends the buffer to 64KB.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TIKA-900) Tika fails to detect ISO9660 disk
images
Posted by "Andrew Jackson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TIKA-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259615#comment-13259615 ]
Andrew Jackson commented on TIKA-900:
-------------------------------------
I re-uploaded the patch as it had an extra format that is not necessary for this patch. Also I noticed a typo in my original issue description. The offset should be 32769, not 37633.
> Tika fails to detect ISO9660 disk images
> ----------------------------------------
>
> Key: TIKA-900
> URL: https://issues.apache.org/jira/browse/TIKA-900
> Project: Tika
> Issue Type: Bug
> Components: mime
> Affects Versions: 1.1
> Environment: Any.
> Reporter: Andrew Jackson
> Priority: Minor
> Attachments: iso-image-detection.patch
>
>
> I have been testing Tika's ability to identify ISO9660 disk image file systems, and discovered two problems. Firstly, the offset match matcher was wrong (37633 instead of 37633). Secondly, and more seriously, it was impossible for that signaure to ever match, because the default buffer size was far to small. It is currently set to 8KB, and as this signature is some 36KB into the file, Tika could never find the match. The attached patch fixes the magic, and extends the buffer to 64KB.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TIKA-900) Tika fails to detect ISO9660 disk
images
Posted by "Andrew Jackson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TIKA-900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Jackson updated TIKA-900:
--------------------------------
Attachment: iso-image-detection.patch
Patch to increase buffer size and fix ISO image detection.
> Tika fails to detect ISO9660 disk images
> ----------------------------------------
>
> Key: TIKA-900
> URL: https://issues.apache.org/jira/browse/TIKA-900
> Project: Tika
> Issue Type: Bug
> Components: mime
> Affects Versions: 1.1
> Environment: Any.
> Reporter: Andrew Jackson
> Priority: Minor
> Attachments: iso-image-detection.patch
>
>
> I have been testing Tika's ability to identify ISO9660 disk image file systems, and discovered two problems. Firstly, the offset match matcher was wrong (37633 instead of 37633). Secondly, and more seriously, it was impossible for that signaure to ever match, because the default buffer size was far to small. It is currently set to 8KB, and as this signature is some 36KB into the file, Tika could never find the match. The attached patch fixes the magic, and extends the buffer to 64KB.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TIKA-900) Tika fails to detect ISO9660 disk
images
Posted by "Andrew Jackson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TIKA-900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Jackson updated TIKA-900:
--------------------------------
Description: I have been testing Tika's ability to identify ISO9660 disk image file systems, and discovered two problems. Firstly, the offset match matcher was wrong (37633 instead of 32769). Secondly, and more seriously, it was impossible for that signaure to ever match, because the default buffer size was far to small. It is currently set to 8KB, and as this signature is some 36KB into the file, Tika could never find the match. The attached patch fixes the magic, and extends the buffer to 64KB. (was: I have been testing Tika's ability to identify ISO9660 disk image file systems, and discovered two problems. Firstly, the offset match matcher was wrong (37633 instead of 37633). Secondly, and more seriously, it was impossible for that signaure to ever match, because the default buffer size was far to small. It is currently set to 8KB, and as this signature is some 36KB into the file, Tika could never find the match. The attached patch fixes the magic, and extends the buffer to 64KB.)
Fixing a typo.
> Tika fails to detect ISO9660 disk images
> ----------------------------------------
>
> Key: TIKA-900
> URL: https://issues.apache.org/jira/browse/TIKA-900
> Project: Tika
> Issue Type: Bug
> Components: mime
> Affects Versions: 1.1
> Environment: Any.
> Reporter: Andrew Jackson
> Priority: Minor
> Attachments: iso-image-detection.patch
>
>
> I have been testing Tika's ability to identify ISO9660 disk image file systems, and discovered two problems. Firstly, the offset match matcher was wrong (37633 instead of 32769). Secondly, and more seriously, it was impossible for that signaure to ever match, because the default buffer size was far to small. It is currently set to 8KB, and as this signature is some 36KB into the file, Tika could never find the match. The attached patch fixes the magic, and extends the buffer to 64KB.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TIKA-900) Tika fails to detect ISO9660 disk
images
Posted by "Andrew Jackson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TIKA-900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Jackson updated TIKA-900:
--------------------------------
Attachment: (was: iso-image-detection.patch)
> Tika fails to detect ISO9660 disk images
> ----------------------------------------
>
> Key: TIKA-900
> URL: https://issues.apache.org/jira/browse/TIKA-900
> Project: Tika
> Issue Type: Bug
> Components: mime
> Affects Versions: 1.1
> Environment: Any.
> Reporter: Andrew Jackson
> Priority: Minor
> Attachments: iso-image-detection.patch
>
>
> I have been testing Tika's ability to identify ISO9660 disk image file systems, and discovered two problems. Firstly, the offset match matcher was wrong (37633 instead of 37633). Secondly, and more seriously, it was impossible for that signaure to ever match, because the default buffer size was far to small. It is currently set to 8KB, and as this signature is some 36KB into the file, Tika could never find the match. The attached patch fixes the magic, and extends the buffer to 64KB.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TIKA-900) Tika fails to detect ISO9660 disk
images
Posted by "Andrew Jackson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TIKA-900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Jackson updated TIKA-900:
--------------------------------
Attachment: iso-image-detection.patch
Patch to fix ISO image magic, and extended the buffer size so that the magic can match.
> Tika fails to detect ISO9660 disk images
> ----------------------------------------
>
> Key: TIKA-900
> URL: https://issues.apache.org/jira/browse/TIKA-900
> Project: Tika
> Issue Type: Bug
> Components: mime
> Affects Versions: 1.1
> Environment: Any.
> Reporter: Andrew Jackson
> Priority: Minor
> Attachments: iso-image-detection.patch
>
>
> I have been testing Tika's ability to identify ISO9660 disk image file systems, and discovered two problems. Firstly, the offset match matcher was wrong (37633 instead of 37633). Secondly, and more seriously, it was impossible for that signaure to ever match, because the default buffer size was far to small. It is currently set to 8KB, and as this signature is some 36KB into the file, Tika could never find the match. The attached patch fixes the magic, and extends the buffer to 64KB.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TIKA-900) Tika fails to detect ISO9660 disk
images
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TIKA-900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting resolved TIKA-900.
--------------------------------
Resolution: Fixed
Fix Version/s: 1.2
Assignee: Jukka Zitting
Thanks! I committed the patch in revision 1355736.
> Tika fails to detect ISO9660 disk images
> ----------------------------------------
>
> Key: TIKA-900
> URL: https://issues.apache.org/jira/browse/TIKA-900
> Project: Tika
> Issue Type: Bug
> Components: mime
> Affects Versions: 1.1
> Environment: Any.
> Reporter: Andrew Jackson
> Assignee: Jukka Zitting
> Priority: Minor
> Fix For: 1.2
>
> Attachments: iso-image-detection.patch
>
>
> I have been testing Tika's ability to identify ISO9660 disk image file systems, and discovered two problems. Firstly, the offset match matcher was wrong (37633 instead of 32769). Secondly, and more seriously, it was impossible for that signaure to ever match, because the default buffer size was far too small. It is currently set to 8KB, and as this signature is some 36KB into the file, Tika could never find the match. The attached patch fixes the magic, and extends the buffer to 64KB.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira