You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Gary Gregory (JIRA)" <ji...@apache.org> on 2017/12/15 21:25:00 UTC
[jira] [Closed] (HTTPCLIENT-1889)
org.apache.http.client.utils.URLEncodedUtils.parse() should return a new
ArrayList when there are no query parameters
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Gregory closed HTTPCLIENT-1889.
------------------------------------
Resolution: Fixed
Fix Version/s: 4.5.5
In git branch 4.5.x.
> org.apache.http.client.utils.URLEncodedUtils.parse() should return a new ArrayList when there are no query parameters
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1889
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1889
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient (classic)
> Affects Versions: 4.5.4
> Reporter: Gary Gregory
> Assignee: Gary Gregory
> Fix For: 4.5.5
>
>
> {{org.apache.http.client.utils.URLEncodedUtils.parse(URI, Charset)}} should return a new {{ArrayList}} when there are no query parameters.
> Currently, {{org.apache.http.client.utils.URLEncodedUtils.parse(URI, Charset)}} returns an immutable list through {{Collections.emptyList()}} if there are no params> But if there are parameters, the method returns a mutable list.
> This makes it impossible to write the same code to handle both cases.
> This change will cause the method to return a new {{ArrayList}} if there are no parameters.
> The methods that are directly affected are:
> - {{org.apache.http.client.utils.URLEncodedUtils.parse(URI, Charset)}}
> - {{org.apache.http.client.utils.URLEncodedUtils.parse(HttpEntity)}}
> - {{org.apache.http.client.utils.URLEncodedUtils.parse(String, Charset)}}
> - {{org.apache.http.client.utils.URLEncodedUtils.parse(String, Charset, char...)}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org