You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/22 08:22:01 UTC

[GitHub] [incubator-superset] github-actions[bot] commented on pull request #10936: feat(dashboards): Filter status indicators

github-actions[bot] commented on pull request #10936:
URL: https://github.com/apache/incubator-superset/pull/10936#issuecomment-696578607


   ### WARNING: Prefer TypeScript
   
   Looks like your PR contains new `.js` or `.jsx` files:
   
   ```
   superset-frontend/spec/javascripts/dashboard/components/FiltersBadge_spec.jsx superset-frontend/src/dashboard/components/FiltersBadge/selectors.js
   ```
   
   As decided in [SIP-36](https://github.com/apache/incubator-superset/issues/9101), all new frontend code should be written in TypeScript. Please convert above files to TypeScript then re-request review.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org