You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "pingww (via GitHub)" <gi...@apache.org> on 2023/02/02 10:47:59 UTC

[GitHub] [rocketmq-mqtt] pingww opened a new pull request, #178: refactor

pingww opened a new pull request, #178:
URL: https://github.com/apache/rocketmq-mqtt/pull/178

   refactor will and retain


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-mqtt] codecov-commenter commented on pull request #178: refactor

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #178:
URL: https://github.com/apache/rocketmq-mqtt/pull/178#issuecomment-1413695909

   # [Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/178?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#178](https://codecov.io/gh/apache/rocketmq-mqtt/pull/178?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0210408) into [develop](https://codecov.io/gh/apache/rocketmq-mqtt/commit/edbfa39a053485880be81882a01536b8d5057aab?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (edbfa39) will **decrease** coverage by `0.20%`.
   > The diff coverage is `12.38%`.
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #178      +/-   ##
   ===========================================
   - Coverage    37.01%   36.81%   -0.20%     
   ===========================================
     Files          128      128              
     Lines         5927     5948      +21     
     Branches       842      841       -1     
   ===========================================
   - Hits          2194     2190       -4     
   - Misses        3367     3392      +25     
     Partials       366      366              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-mqtt/pull/178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...rocketmq/mqtt/cs/session/loop/SessionLoopImpl.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9zZXNzaW9uL2xvb3AvU2Vzc2lvbkxvb3BJbXBsLmphdmE=) | `42.89% <ø> (+9.70%)` | :arrow_up: |
   | [...apache/rocketmq/mqtt/cs/session/loop/WillLoop.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9zZXNzaW9uL2xvb3AvV2lsbExvb3AuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rg/apache/rocketmq/mqtt/ds/meta/MetaRpcClient.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1kcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9kcy9tZXRhL01ldGFScGNDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../rocketmq/mqtt/example/MqttWillRetainConsumer.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1leGFtcGxlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9tcXR0L2V4YW1wbGUvTXF0dFdpbGxSZXRhaW5Db25zdW1lci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../rocketmq/mqtt/example/MqttWillRetainProducer.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1leGFtcGxlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9tcXR0L2V4YW1wbGUvTXF0dFdpbGxSZXRhaW5Qcm9kdWNlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...org/apache/rocketmq/mqtt/meta/config/MetaConf.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1tZXRhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9tcXR0L21ldGEvY29uZmlnL01ldGFDb25mLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ache/rocketmq/mqtt/meta/raft/MqttStateMachine.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1tZXRhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9tcXR0L21ldGEvcmFmdC9NcXR0U3RhdGVNYWNoaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...meta/raft/processor/RetainedMsgStateProcessor.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1tZXRhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9tcXR0L21ldGEvcmFmdC9wcm9jZXNzb3IvUmV0YWluZWRNc2dTdGF0ZVByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...qtt/meta/raft/processor/WillMsgStateProcessor.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1tZXRhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9tcXR0L21ldGEvcmFmdC9wcm9jZXNzb3IvV2lsbE1zZ1N0YXRlUHJvY2Vzc29yLmphdmE=) | `8.88% <ø> (-28.92%)` | :arrow_down: |
   | [...he/rocketmq/mqtt/meta/rocksdb/RocksDBSnapshot.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1tZXRhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9tcXR0L21ldGEvcm9ja3NkYi9Sb2Nrc0RCU25hcHNob3QuamF2YQ==) | `5.00% <ø> (ø)` | |
   | ... and [2 more](https://codecov.io/gh/apache/rocketmq-mqtt/pull/178?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-mqtt] pingww merged pull request #178: refactor

Posted by "pingww (via GitHub)" <gi...@apache.org>.
pingww merged PR #178:
URL: https://github.com/apache/rocketmq-mqtt/pull/178


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org