[GitHub] [inlong] healchow commented on a diff in pull request #5792: [INLONG-5788][DataProxy] Fix the incorrect readFailSize metric value

[GitBox <gi...@apache.org>]

healchow commented on code in PR #5792:
URL: https://github.com/apache/inlong/pull/5792#discussion_r963293298


##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/TubeSink.java:
##########
@@ -285,7 +285,7 @@ public Status process() throws EventDeliveryException {
                     cachedMsgCnt.incrementAndGet();
                     DataProxyMetricItem metricItem = this.metricItemSet.findMetricItem(dimensions);
                     metricItem.readSuccessCount.incrementAndGet();
-                    metricItem.readFailSize.addAndGet(event.getBody().length);
+                    metricItem.readSuccessSize.addAndGet(event.getBody().length);
                 } else {
                     tx.rollback();
                     //logger.info("[{}] Channel --> Queue(has no enough space,current code point) "

Review Comment:
   Could you please remove those unused log codes at the same time?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org