You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by ji...@codehaus.org on 2003/12/02 22:46:56 UTC
[jira] Updated: (GERONIMO-122) Proposed refactorings for o.a.g.kernel.deployment.goal.*
The following issue has been updated:
Updater: Ed Letifov (mailto:techtime@ic.ru)
Date: Tue, 2 Dec 2003 3:46 PM
Comment:
Since I have to operate from what I see in today's implementation the patch might seem somewhat ugly.
Changes:
Attachment changed to patch1.jar
---------------------------------------------------------------------
For a full history of the issue, see:
http://jira.codehaus.org/secure/ViewIssue.jspa?key=GERONIMO-122&page=history
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/secure/ViewIssue.jspa?key=GERONIMO-122
Here is an overview of the issue:
---------------------------------------------------------------------
Key: GERONIMO-122
Summary: Proposed refactorings for o.a.g.kernel.deployment.goal.*
Type: Improvement
Status: Unassigned
Priority: Trivial
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: Apache Geronimo
Assignee:
Reporter: Ed Letifov
Created: Tue, 2 Dec 2003 3:44 PM
Updated: Tue, 2 Dec 2003 3:46 PM
Description:
I am under impression that some classes in o.a.g.kernel.deployment.goal.* can (should?) be refactored just a little to facilitate more reuse between them. IMHO an abstract class would be welcome in the hierarchy to reduce copy paste in the implementation (and also make tests simpler)
I have some concerns about UndeployURL and RedeployURL that do not behave in the same way as other two: they do not normalize file-protocol based URLs and seem to accept null values for the arguments in the constructors. Is it in fact how it is supposed to be?
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira