You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Ian Clelland <ic...@google.com> on 2013/11/04 20:34:13 UTC
File API tests
So I've *just* completed rewriting all 105 File API tests to the new
(Jasmine 2) style. They're much more readable, and hopefully more
maintainable now.
You can follow along on the cdvtest branch of cordova-file-plugin, if
you're using Michal's new test framework.
There are 2 failing tests, which actually failed undetected previously.
I'll see if I can push a fix for those two later today.
Ian
Re: File API tests
Posted by Brian LeRoux <b...@brian.io>.
Nice =)
On Tue, Nov 5, 2013 at 8:51 PM, Ian Clelland <ic...@chromium.org> wrote:
> On Mon, Nov 4, 2013 at 1:47 PM, Michal Mocny <mm...@chromium.org> wrote:
>
> > Easier to read and catching errors that had gone undetected for a long
> > time?
> >
> > Sounds like a ringing endorsement to me ;)
> >
>
> Oh -- and smaller, too :)
>
> The test suite dropped 1300 lines -- from 3831 lines to 2550 (-33%)
>
> Definitely a win.
>
>
> >
> > On Mon, Nov 4, 2013 at 2:34 PM, Ian Clelland <ic...@google.com>
> wrote:
> >
> > > So I've *just* completed rewriting all 105 File API tests to the new
> > > (Jasmine 2) style. They're much more readable, and hopefully more
> > > maintainable now.
> > >
> > > You can follow along on the cdvtest branch of cordova-file-plugin, if
> > > you're using Michal's new test framework.
> > >
> > > There are 2 failing tests, which actually failed undetected previously.
> > > I'll see if I can push a fix for those two later today.
> > >
> > > Ian
> > >
> >
>
Re: File API tests
Posted by Ian Clelland <ic...@chromium.org>.
On Mon, Nov 4, 2013 at 1:47 PM, Michal Mocny <mm...@chromium.org> wrote:
> Easier to read and catching errors that had gone undetected for a long
> time?
>
> Sounds like a ringing endorsement to me ;)
>
Oh -- and smaller, too :)
The test suite dropped 1300 lines -- from 3831 lines to 2550 (-33%)
Definitely a win.
>
> On Mon, Nov 4, 2013 at 2:34 PM, Ian Clelland <ic...@google.com> wrote:
>
> > So I've *just* completed rewriting all 105 File API tests to the new
> > (Jasmine 2) style. They're much more readable, and hopefully more
> > maintainable now.
> >
> > You can follow along on the cdvtest branch of cordova-file-plugin, if
> > you're using Michal's new test framework.
> >
> > There are 2 failing tests, which actually failed undetected previously.
> > I'll see if I can push a fix for those two later today.
> >
> > Ian
> >
>
Re: File API tests
Posted by Michal Mocny <mm...@chromium.org>.
Easier to read and catching errors that had gone undetected for a long time?
Sounds like a ringing endorsement to me ;)
On Mon, Nov 4, 2013 at 2:34 PM, Ian Clelland <ic...@google.com> wrote:
> So I've *just* completed rewriting all 105 File API tests to the new
> (Jasmine 2) style. They're much more readable, and hopefully more
> maintainable now.
>
> You can follow along on the cdvtest branch of cordova-file-plugin, if
> you're using Michal's new test framework.
>
> There are 2 failing tests, which actually failed undetected previously.
> I'll see if I can push a fix for those two later today.
>
> Ian
>