You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/11/03 14:14:16 UTC
[GitHub] [cloudstack] Spaceman1984 opened a new pull request #4439: Added compress option to dnsmasq
Spaceman1984 opened a new pull request #4439:
URL: https://github.com/apache/cloudstack/pull/4439
## Description
<!--- Describe your changes in detail -->
This PR adds compression to dnsmasq log files
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
Log into virtual router
Check /var/log/ directory, observe dnsmasq.log
Change system time 1 day ahead and reboot VR
Check /var/log/ directory, observe dnsmasq.log, dnsmasq.log1
Change system time 1 day ahead and reboot VR
There should be 3 log files now and 1 should be compressed
Check /var/log/ directory, observe dnsmasq.log, dnsmasq.log1, dnsmasq.log.2.gz
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4439: Added compress option to dnsmasq log files
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4439:
URL: https://github.com/apache/cloudstack/pull/4439#issuecomment-721665574
Simple enough change, let's merge for master @DaanHoogland ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4439: Added compress option to dnsmasq log files
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4439:
URL: https://github.com/apache/cloudstack/pull/4439#issuecomment-720990032
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 removed a comment on pull request #4439: Added compress option to dnsmasq log files
Posted by GitBox <gi...@apache.org>.
Spaceman1984 removed a comment on pull request #4439:
URL: https://github.com/apache/cloudstack/pull/4439#issuecomment-721002777
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4439: Added compress option to dnsmasq log files
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4439:
URL: https://github.com/apache/cloudstack/pull/4439#issuecomment-721326671
<b>Trillian test result (tid-3119)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31996 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4439-t3119-kvm-centos7.zip
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4439: Added compress option to dnsmasq log files
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4439:
URL: https://github.com/apache/cloudstack/pull/4439#issuecomment-722978534
@PaulAngus merging this as it is small and not intrusive. cc @GabrielBrascher @weizhouapache.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #4439: Added compress option to dnsmasq log files
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #4439:
URL: https://github.com/apache/cloudstack/pull/4439
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4439: Added compress option to dnsmasq log files
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4439:
URL: https://github.com/apache/cloudstack/pull/4439#issuecomment-720990731
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org