[GitHub] [accumulo] milleruntime edited a comment on issue #1789: Broken test: LargestFirstMemoryManagerTest

[GitBox <gi...@apache.org>]

milleruntime edited a comment on issue #1789:
URL: https://github.com/apache/accumulo/issues/1789#issuecomment-778165056


   There are timing elements to the `LargestFirstMemoryManager` that I think will cause it to behave differently if the test takes too long to run. For instance, there is a variable that is clocked when the class is loaded (`ZERO_TIME`) that is used to compare for compaction idle times. The value here could become over 15 minutes (`getMinCIdleThreshold()`one of the overridden methods returns):
   https://github.com/apache/accumulo/blob/906aef9101b04c956dee71625590d79fdc7d97d4/server/tserver/src/main/java/org/apache/accumulo/tserver/memory/LargestFirstMemoryManager.java#L184
   The commit times in the test are set to the time the class is loaded, so the idle time can vary, depending when classes were loaded.
   
   The test shouldn't take longer than 1 minute (it takes just over 1 second on my machine) so if there is a way we can add a timeout, we should.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org