You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajitha R <ra...@gmail.com> on 2017/06/15 09:50:11 UTC
Review Request 60115: Unit test cases for Virtual fact
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60115/
-----------------------------------------------------------
Review request for lens and Amareshwari Sriramadasu.
Repository: lens
Description
-------
Unit test cases for Virtual fact
Diffs
-----
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 48869c2
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java d8c7335
lens-cube/src/test/java/org/apache/lens/cube/parse/TestVirtualFactQueries.java PRE-CREATION
lens-cube/src/test/resources/schema/cubes/base/testcube2.xml PRE-CREATION
lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml 2a5e0b0
lens-cube/src/test/resources/schema/facts/testfact7_base.xml PRE-CREATION
lens-cube/src/test/resources/schema/facts/testfact8_base.xml PRE-CREATION
lens-cube/src/test/resources/schema/facts/testfact9_base.xml PRE-CREATION
lens-cube/src/test/resources/schema/facts/virtual/virtualfact.xml 860965f
Diff: https://reviews.apache.org/r/60115/diff/1/
Testing
-------
Thanks,
Rajitha R
Re: Review Request 60115: Unit test cases for Virtual fact
[LENS-1437] and fix in virtual fact update command [LENS-1440]
Posted by Rajitha R <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60115/
-----------------------------------------------------------
(Updated June 16, 2017, 2:32 p.m.)
Review request for lens and Amareshwari Sriramadasu.
Bugs: LENS-1437 and LENS-1440
https://issues.apache.org/jira/browse/LENS-1437
https://issues.apache.org/jira/browse/LENS-1440
Repository: lens
Description
-------
Unit test cases for Virtual fact
Fix in virtual fact update command in schema
Diffs
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java aca1cf9
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 48869c2
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java d8c7335
lens-cube/src/test/java/org/apache/lens/cube/parse/TestVirtualFactQueries.java PRE-CREATION
lens-cube/src/test/resources/schema/cubes/base/testcube2.xml PRE-CREATION
lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml 2a5e0b0
lens-cube/src/test/resources/schema/facts/testfact7_base.xml PRE-CREATION
lens-cube/src/test/resources/schema/facts/testfact8_base.xml PRE-CREATION
lens-cube/src/test/resources/schema/facts/testfact9_base.xml PRE-CREATION
lens-cube/src/test/resources/schema/facts/virtual/virtualfact.xml 860965f
Diff: https://reviews.apache.org/r/60115/diff/2/
Testing
-------
Thanks,
Rajitha R
Re: Review Request 60115: Unit test cases for Virtual fact
[LENS-1437] and fix in virtual fact update command [LENS-1440]
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60115/#review178091
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On June 15, 2017, 9:16 p.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60115/
> -----------------------------------------------------------
>
> (Updated June 15, 2017, 9:16 p.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Unit test cases for Virtual fact
> Fix in virtual fact update command in schema
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java aca1cf9
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 48869c2
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java d8c7335
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestVirtualFactQueries.java PRE-CREATION
> lens-cube/src/test/resources/schema/cubes/base/testcube2.xml PRE-CREATION
> lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml 2a5e0b0
> lens-cube/src/test/resources/schema/facts/testfact7_base.xml PRE-CREATION
> lens-cube/src/test/resources/schema/facts/testfact8_base.xml PRE-CREATION
> lens-cube/src/test/resources/schema/facts/testfact9_base.xml PRE-CREATION
> lens-cube/src/test/resources/schema/facts/virtual/virtualfact.xml 860965f
>
>
> Diff: https://reviews.apache.org/r/60115/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 60115: Unit test cases for Virtual fact
[LENS-1437] and fix in virtual fact update command [LENS-1440]
Posted by Rajitha R <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60115/
-----------------------------------------------------------
(Updated June 15, 2017, 3:46 p.m.)
Review request for lens and Amareshwari Sriramadasu.
Summary (updated)
-----------------
Unit test cases for Virtual fact [LENS-1437] and fix in virtual fact update command [LENS-1440]
Repository: lens
Description (updated)
-------
Unit test cases for Virtual fact
Fix in virtual fact update command in schema
Diffs (updated)
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java aca1cf9
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 48869c2
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java d8c7335
lens-cube/src/test/java/org/apache/lens/cube/parse/TestVirtualFactQueries.java PRE-CREATION
lens-cube/src/test/resources/schema/cubes/base/testcube2.xml PRE-CREATION
lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml 2a5e0b0
lens-cube/src/test/resources/schema/facts/testfact7_base.xml PRE-CREATION
lens-cube/src/test/resources/schema/facts/testfact8_base.xml PRE-CREATION
lens-cube/src/test/resources/schema/facts/testfact9_base.xml PRE-CREATION
lens-cube/src/test/resources/schema/facts/virtual/virtualfact.xml 860965f
Diff: https://reviews.apache.org/r/60115/diff/2/
Changes: https://reviews.apache.org/r/60115/diff/1-2/
Testing
-------
Thanks,
Rajitha R
Re: Review Request 60115: Unit test cases for Virtual fact [LENS-1437]
Posted by Rajitha R <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60115/
-----------------------------------------------------------
(Updated June 15, 2017, 3:36 p.m.)
Review request for lens and Amareshwari Sriramadasu.
Summary (updated)
-----------------
Unit test cases for Virtual fact [LENS-1437]
Repository: lens
Description
-------
Unit test cases for Virtual fact
Diffs
-----
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 48869c2
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java d8c7335
lens-cube/src/test/java/org/apache/lens/cube/parse/TestVirtualFactQueries.java PRE-CREATION
lens-cube/src/test/resources/schema/cubes/base/testcube2.xml PRE-CREATION
lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml 2a5e0b0
lens-cube/src/test/resources/schema/facts/testfact7_base.xml PRE-CREATION
lens-cube/src/test/resources/schema/facts/testfact8_base.xml PRE-CREATION
lens-cube/src/test/resources/schema/facts/testfact9_base.xml PRE-CREATION
lens-cube/src/test/resources/schema/facts/virtual/virtualfact.xml 860965f
Diff: https://reviews.apache.org/r/60115/diff/1/
Testing
-------
Thanks,
Rajitha R