You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/03/16 10:13:18 UTC
[GitHub] [james-project] LanKhuat opened a new pull request #333: Method for docker file copy
LanKhuat opened a new pull request #333:
URL: https://github.com/apache/james-project/pull/333
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #333: JAMES-3518: Method for docker file copy
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #333:
URL: https://github.com/apache/james-project/pull/333#issuecomment-800265953
I guess the context is reuse of this class in an external project.
Either the external use could:
- use genericContainer directly
- duplicate and adapt this class
- maybe the smartest way around is to expose a method to manipulate the raw container (consumer<genericContainer>¿) and refactor this class to use it? This one would imo be the best option...
We shall remove - and not write dead code.
But james is also a toolkit to assemble email server. Imo we can introduce genericity not needed as part of james server as long as:
- we test it
- we document it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on pull request #333: JAMES-3518: Method for docker file copy
Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #333:
URL: https://github.com/apache/james-project/pull/333#issuecomment-800288843
> I guess the context is reuse of this class in an external project.
Considering what the class does, I wonder if the test container project would be open to a contribution or if a : this class has nothing James specific that I can spot ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] LanKhuat commented on pull request #333: JAMES-3518: Method for docker file copy
Posted by GitBox <gi...@apache.org>.
LanKhuat commented on pull request #333:
URL: https://github.com/apache/james-project/pull/333#issuecomment-800766064
Agreed. This change is for an external project that depending on James and does not bring anything useful to James itself. I found a work around and this is no longer needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on pull request #333: JAMES-3518: Method for docker file copy
Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #333:
URL: https://github.com/apache/james-project/pull/333#issuecomment-800163248
I'm sorry, I don't understand the purpose of this change.
As it stands all it does is add an **unused** method to DockerContainer, and the description in JAMES-3518 doesn't help understand why it is desirable to have a new unused method there. If sonar was setup on the project, the checks would definitely not pass for the PR as it stands.
If you need this change as part of a larger change, please include it in that larger PR. This way the PR will offer context on how and why you need this change ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #333: Method for docker file copy
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #333:
URL: https://github.com/apache/james-project/pull/333#issuecomment-800130844
No ticket number? No explanation why this is needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] LanKhuat closed pull request #333: JAMES-3518: Method for docker file copy
Posted by GitBox <gi...@apache.org>.
LanKhuat closed pull request #333:
URL: https://github.com/apache/james-project/pull/333
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org