[karaf] branch main updated: [KARAF-7580] Prevent StringIndexOutOfBoundsException on help with newlines

[jb...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

jbonofre pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/karaf.git


The following commit(s) were added to refs/heads/main by this push:
     new e99eb51a51 [KARAF-7580] Prevent StringIndexOutOfBoundsException on help with newlines
     new c7b158e086 Merge pull request #1659 from seeburger-ag/KARAF-7580
e99eb51a51 is described below

commit e99eb51a5127093933d81164e7fbea75c22f380a
Author: Rico Neubauer <r....@seeburger.de>
AuthorDate: Fri Oct 14 09:09:43 2022 +0200

    [KARAF-7580] Prevent StringIndexOutOfBoundsException on help with newlines
    
    Avoids
    java.lang.StringIndexOutOfBoundsException: index -1, length 0
        at java.lang.String.checkIndex(String.java:4563) ~[?:?]
        at java.lang.AbstractStringBuilder.charAt(AbstractStringBuilder.java:351) ~[?:?]
        at java.lang.StringBuilder.charAt(StringBuilder.java:91) ~[?:?]
        at org.apache.karaf.shell.support.table.Row.getContent(Row.java:84) ~[?:?]
        at org.apache.karaf.shell.support.table.ShellTable.print(ShellTable.java:151) ~[?:?]
        at org.apache.karaf.shell.support.table.ShellTable.print(ShellTable.java:111) ~[?:?]
        at org.apache.karaf.shell.impl.console.commands.help.CommandListHelpProvider.printMethodList(CommandListHelpProvider.java:167) ~[?:?]
---
 shell/core/src/main/java/org/apache/karaf/shell/support/table/Row.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/shell/core/src/main/java/org/apache/karaf/shell/support/table/Row.java b/shell/core/src/main/java/org/apache/karaf/shell/support/table/Row.java
index 8a8dbd6963..c009b7f109 100644
--- a/shell/core/src/main/java/org/apache/karaf/shell/support/table/Row.java
+++ b/shell/core/src/main/java/org/apache/karaf/shell/support/table/Row.java
@@ -81,7 +81,7 @@ public class Row {
                     st2.append(StringUtil.repeat(" ", cols.get(col).getSize()));
                 }
             }
-            while (st2.charAt(st2.length() - 1) == ' ') {
+            while (st2.length() > 0 && st2.charAt(st2.length() - 1) == ' ') {
                 st2.setLength(st2.length() - 1);
             }
             st.append(st2);