You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/07/29 10:11:25 UTC

[GitHub] [dolphinscheduler] zhuangchong opened a new issue #5918: [Improvement][Common] Remove the code logger.isDebugEnabled()

zhuangchong opened a new issue #5918:
URL: https://github.com/apache/dolphinscheduler/issues/5918


   **Describe the question**
   1. When the log is printed using string splicing, when the program judges the level of the print log, it will splice the log information of the string first. If the sentence does not print the string in the end, then this spliced string The process is a meaningless operation, which will increase the loss of system performance. At this time, it is recommended to use logger.isDebugEnabled()
   
   2. Use the {} placeholder to print the log, there is no need to prejudge the level of the log, the bottom layer has already implemented this step.
   
   The current system uses {} placeholders to print logs, so remove the code logger.isDebugEnabled().
   
   **What are the current deficiencies and the benefits of improvement**
   - Repeated calls to determine whether it is debug log level
   
   **Which version of DolphinScheduler:**
    -[dev]
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #5918: [Improvement][Common] Remove the code logger.isDebugEnabled()

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #5918:
URL: https://github.com/apache/dolphinscheduler/issues/5918#issuecomment-888989523


   Hi:
   * Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
   * In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
   * If you haven't received a reply for a long time, you can subscribe to the developer's email,Mail subscription steps reference https://dolphinscheduler.apache.org/zh-cn/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org