You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@karaf.apache.org by "Jamie G." <ja...@gmail.com> on 2011/11/28 15:40:51 UTC
Assembly/Assemblies clean up
Hi All,
I've been looking through our assemblies setup for Karaf trunk and
would like to know if we can remove the following folders:
http://svn.apache.org/repos/asf/karaf/trunk/assemblies/apache-karaf-full/
<-- empty folder, is this a place holder?
http://svn.apache.org/repos/asf/karaf/trunk/assemblies/features/full/
<-- appears to be unused.
http://svn.apache.org/repos/asf/karaf/trunk/assembly/ <--- appears to
be deprecated.
Cheers,
Jamie
Re: Assembly/Assemblies clean up
Posted by Achim Nierbeck <bc...@googlemail.com>.
Hi Jamie,
AFAIC +1 from my side.
I guess we can get rid of the old stuff now :)
regards, Achim
2011/11/28 Jamie G. <ja...@gmail.com>
> Hi All,
>
> I've been looking through our assemblies setup for Karaf trunk and
> would like to know if we can remove the following folders:
>
> http://svn.apache.org/repos/asf/karaf/trunk/assemblies/apache-karaf-full/
> <-- empty folder, is this a place holder?
> http://svn.apache.org/repos/asf/karaf/trunk/assemblies/features/full/
> <-- appears to be unused.
> http://svn.apache.org/repos/asf/karaf/trunk/assembly/ <--- appears to
> be deprecated.
>
> Cheers,
> Jamie
>
--
Apache Karaf <http://karaf.apache.org/> Committer & PMC
OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> Committer &
Project Lead
blog <http://notizblog.nierbeck.de/>
Re: Assembly/Assemblies clean up
Posted by "Jamie G." <ja...@gmail.com>.
Hmm, in the main pom file there is a reference to the 'assembly'
module in regards to using eclipse.
Perhaps this is something else that may require re-factoring as well?
On Mon, Nov 28, 2011 at 12:21 PM, Jamie G. <ja...@gmail.com> wrote:
> Sounds good, I'll take care of removing them then :)
>
> Cheers,
> Jamie
>
> On Mon, Nov 28, 2011 at 11:33 AM, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
>> Hi Jamie,
>>
>> yes, these folders could be removed (git svn doesn't do it).
>>
>> Regards
>> JB
>>
>> On 11/28/2011 03:40 PM, Jamie G. wrote:
>>>
>>> Hi All,
>>>
>>> I've been looking through our assemblies setup for Karaf trunk and
>>> would like to know if we can remove the following folders:
>>>
>>> http://svn.apache.org/repos/asf/karaf/trunk/assemblies/apache-karaf-full/
>>> <-- empty folder, is this a place holder?
>>> http://svn.apache.org/repos/asf/karaf/trunk/assemblies/features/full/
>>> <-- appears to be unused.
>>> http://svn.apache.org/repos/asf/karaf/trunk/assembly/<--- appears to
>>> be deprecated.
>>>
>>> Cheers,
>>> Jamie
>>
>> --
>> Jean-Baptiste Onofré
>> jbonofre@apache.org
>> http://blog.nanthrax.net
>> Talend - http://www.talend.com
>>
>
Re: Assembly/Assemblies clean up
Posted by "Jamie G." <ja...@gmail.com>.
Sounds good, I'll take care of removing them then :)
Cheers,
Jamie
On Mon, Nov 28, 2011 at 11:33 AM, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
> Hi Jamie,
>
> yes, these folders could be removed (git svn doesn't do it).
>
> Regards
> JB
>
> On 11/28/2011 03:40 PM, Jamie G. wrote:
>>
>> Hi All,
>>
>> I've been looking through our assemblies setup for Karaf trunk and
>> would like to know if we can remove the following folders:
>>
>> http://svn.apache.org/repos/asf/karaf/trunk/assemblies/apache-karaf-full/
>> <-- empty folder, is this a place holder?
>> http://svn.apache.org/repos/asf/karaf/trunk/assemblies/features/full/
>> <-- appears to be unused.
>> http://svn.apache.org/repos/asf/karaf/trunk/assembly/<--- appears to
>> be deprecated.
>>
>> Cheers,
>> Jamie
>
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
>
Re: Assembly/Assemblies clean up
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi Jamie,
yes, these folders could be removed (git svn doesn't do it).
Regards
JB
On 11/28/2011 03:40 PM, Jamie G. wrote:
> Hi All,
>
> I've been looking through our assemblies setup for Karaf trunk and
> would like to know if we can remove the following folders:
>
> http://svn.apache.org/repos/asf/karaf/trunk/assemblies/apache-karaf-full/
> <-- empty folder, is this a place holder?
> http://svn.apache.org/repos/asf/karaf/trunk/assemblies/features/full/
> <-- appears to be unused.
> http://svn.apache.org/repos/asf/karaf/trunk/assembly/<--- appears to
> be deprecated.
>
> Cheers,
> Jamie
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: Assembly/Assemblies clean up
Posted by "Jamie G." <ja...@gmail.com>.
In my review & testing I didn't see any references to using
assemblies/features/full but if I was mistaken then I'll have to
restore the structures or replace them in another location.
The only reference I have noticed for apache-karaf-full is under
developers-guide/writing-tests.conf, but this probably needed to be
updated to reflect the rename to apache-karaf.
Cheers,
Jamie
On Mon, Nov 28, 2011 at 6:01 PM, David Jencks <da...@yahoo.com> wrote:
> Hi Jean-Baptiste,
>
> There are/were two "fulls".
>
> - assemblies/apache-karaf-full, renamed to apache-karaf. I have no problem with this, I named it -full so we could keep the old apache-karaf assembly around for a short while to make sure I didn't leave out too much.
>
> - assemblies/features/full This was a kar that included resources in the full assembly that weren't in (or shouldn't be in) the minimal assembly, and also IIRC pulled in a few bundles needed for the full assembly. I don't think removing this was wise, and the last time I looked there were some missing bundles as a result. However I don't remember the details.
>
> thanks
> david jencks
>
> On Nov 28, 2011, at 9:08 AM, Jean-Baptiste Onofré wrote:
>
>> Hi David,
>>
>> Could you explain ?
>>
>> IMO, to provide a "smooth" transition, users should more or less get the same distribution.
>>
>> Introducing -full wasn't good for me as people will look for apache-karaf.
>>
>> Full is now presents directly in apache-karaf. It's exactly the same.
>>
>> Regards
>> JB
>>
>> On 11/28/2011 05:59 PM, David Jencks wrote:
>>> I still think that removing assemblies/features/full was a mistake (IIRC I -1'ed it with no response) and haven't found where the stuff in it was restored (if anywhere).
>>>
>>> david jencks
>>>
>>> On Nov 28, 2011, at 6:40 AM, Jamie G. wrote:
>>>
>>>> Hi All,
>>>>
>>>> I've been looking through our assemblies setup for Karaf trunk and
>>>> would like to know if we can remove the following folders:
>>>>
>>>> http://svn.apache.org/repos/asf/karaf/trunk/assemblies/apache-karaf-full/
>>>> <-- empty folder, is this a place holder?
>>>> http://svn.apache.org/repos/asf/karaf/trunk/assemblies/features/full/
>>>> <-- appears to be unused.
>>>> http://svn.apache.org/repos/asf/karaf/trunk/assembly/<--- appears to
>>>> be deprecated.
>>>>
>>>> Cheers,
>>>> Jamie
>>>
>>
>> --
>> Jean-Baptiste Onofré
>> jbonofre@apache.org
>> http://blog.nanthrax.net
>> Talend - http://www.talend.com
>
>
Re: Assembly/Assemblies clean up
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
I got your point.
But, AFAIR, I moved it into standard, not framework. I will fix that today.
My concern is that full doesn't mean anything for me.
Framework and minimal are clear and used by others projects.
Standard is destinated to the end-users.
I don't see any value to a "Full" feature.
Anyway, I'm gonna take a look and fix the framework.
Regards
JB
On 11/29/2011 08:01 AM, David Jencks wrote:
> OK, I looked up a bit what the problem was. See rev. 1188071 and the discussion about it.
>
> The full kar installed some deployers that shouldn't be in the minimal assembly but were in the "full" assembly. Rev. 1188071 erroneously added them to the framework. I really think we need to fix this before releasing. These are the deployers:
>
> <bundle start="true" start-level="30">mvn:org.apache.karaf.deployer/org.apache.karaf.deployer.spring/${project.version}</bundle>
> <bundle start="true" start-level="30">mvn:org.apache.karaf.deployer/org.apache.karaf.deployer.blueprint/${project.version}</bundle>
> <bundle start="true" start-level="30">mvn:org.apache.karaf.deployer/org.apache.karaf.deployer.features/${project.version}</bundle>
> <bundle start="true" start-level="30">mvn:org.apache.karaf.deployer/org.apache.karaf.deployer.kar/${project.version}</bundle>
> <bundle start="true" start-level="30">mvn:org.apache.karaf.deployer/org.apache.karaf.deployer.wrap/${project.version}</bundle>
>
>
> I think there were some differences in cfg files as well, although I don't think I straightened out all the duplication of cfg files between the full and framework kars. Maybe the cfg files were identical.
>
> Actually there are currently one kar (framework) and two feature repos (standard and enterprise). If there were no important differences between the resources such as cfg files then maybe we can have a "deployer" feature in standard with the 4 non-spring deployers and put the spring deployer in with some spring feature?
>
> Also I think we should put all the spring related features in a spring feature repo so it's easier to have a spring-free karaf if you want it.
>
>
> thanks
> david jencks
>
> On Nov 28, 2011, at 9:57 PM, Jean-Baptiste Onofré wrote:
>
>> Hi David,
>>
>> yes I saw that. I removed that because I don't see the advantage of the full kar comparing to the standard one. The standard kar contains the same thing as the full (as we have currently in the karaf 2.2.x).
>>
>> Basically, we have three kar:
>> - framework
>> - minimal
>> - standard
>>
>> Regards
>> JB
>>
>> On 11/28/2011 10:31 PM, David Jencks wrote:
>>> Hi Jean-Baptiste,
>>>
>>> There are/were two "fulls".
>>>
>>> - assemblies/apache-karaf-full, renamed to apache-karaf. I have no problem with this, I named it -full so we could keep the old apache-karaf assembly around for a short while to make sure I didn't leave out too much.
>>>
>>> - assemblies/features/full This was a kar that included resources in the full assembly that weren't in (or shouldn't be in) the minimal assembly, and also IIRC pulled in a few bundles needed for the full assembly. I don't think removing this was wise, and the last time I looked there were some missing bundles as a result. However I don't remember the details.
>>>
>>> thanks
>>> david jencks
>>>
>>> On Nov 28, 2011, at 9:08 AM, Jean-Baptiste Onofré wrote:
>>>
>>>> Hi David,
>>>>
>>>> Could you explain ?
>>>>
>>>> IMO, to provide a "smooth" transition, users should more or less get the same distribution.
>>>>
>>>> Introducing -full wasn't good for me as people will look for apache-karaf.
>>>>
>>>> Full is now presents directly in apache-karaf. It's exactly the same.
>>>>
>>>> Regards
>>>> JB
>>>>
>>>> On 11/28/2011 05:59 PM, David Jencks wrote:
>>>>> I still think that removing assemblies/features/full was a mistake (IIRC I -1'ed it with no response) and haven't found where the stuff in it was restored (if anywhere).
>>>>>
>>>>> david jencks
>>>>>
>>>>> On Nov 28, 2011, at 6:40 AM, Jamie G. wrote:
>>>>>
>>>>>> Hi All,
>>>>>>
>>>>>> I've been looking through our assemblies setup for Karaf trunk and
>>>>>> would like to know if we can remove the following folders:
>>>>>>
>>>>>> http://svn.apache.org/repos/asf/karaf/trunk/assemblies/apache-karaf-full/
>>>>>> <-- empty folder, is this a place holder?
>>>>>> http://svn.apache.org/repos/asf/karaf/trunk/assemblies/features/full/
>>>>>> <-- appears to be unused.
>>>>>> http://svn.apache.org/repos/asf/karaf/trunk/assembly/<--- appears to
>>>>>> be deprecated.
>>>>>>
>>>>>> Cheers,
>>>>>> Jamie
>>>>>
>>>>
>>>> --
>>>> Jean-Baptiste Onofré
>>>> jbonofre@apache.org
>>>> http://blog.nanthrax.net
>>>> Talend - http://www.talend.com
>>>
>>
>> --
>> Jean-Baptiste Onofré
>> jbonofre@apache.org
>> http://blog.nanthrax.net
>> Talend - http://www.talend.com
>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: Assembly/Assemblies clean up
Posted by David Jencks <da...@yahoo.com>.
OK, I looked up a bit what the problem was. See rev. 1188071 and the discussion about it.
The full kar installed some deployers that shouldn't be in the minimal assembly but were in the "full" assembly. Rev. 1188071 erroneously added them to the framework. I really think we need to fix this before releasing. These are the deployers:
<bundle start="true" start-level="30">mvn:org.apache.karaf.deployer/org.apache.karaf.deployer.spring/${project.version}</bundle>
<bundle start="true" start-level="30">mvn:org.apache.karaf.deployer/org.apache.karaf.deployer.blueprint/${project.version}</bundle>
<bundle start="true" start-level="30">mvn:org.apache.karaf.deployer/org.apache.karaf.deployer.features/${project.version}</bundle>
<bundle start="true" start-level="30">mvn:org.apache.karaf.deployer/org.apache.karaf.deployer.kar/${project.version}</bundle>
<bundle start="true" start-level="30">mvn:org.apache.karaf.deployer/org.apache.karaf.deployer.wrap/${project.version}</bundle>
I think there were some differences in cfg files as well, although I don't think I straightened out all the duplication of cfg files between the full and framework kars. Maybe the cfg files were identical.
Actually there are currently one kar (framework) and two feature repos (standard and enterprise). If there were no important differences between the resources such as cfg files then maybe we can have a "deployer" feature in standard with the 4 non-spring deployers and put the spring deployer in with some spring feature?
Also I think we should put all the spring related features in a spring feature repo so it's easier to have a spring-free karaf if you want it.
thanks
david jencks
On Nov 28, 2011, at 9:57 PM, Jean-Baptiste Onofré wrote:
> Hi David,
>
> yes I saw that. I removed that because I don't see the advantage of the full kar comparing to the standard one. The standard kar contains the same thing as the full (as we have currently in the karaf 2.2.x).
>
> Basically, we have three kar:
> - framework
> - minimal
> - standard
>
> Regards
> JB
>
> On 11/28/2011 10:31 PM, David Jencks wrote:
>> Hi Jean-Baptiste,
>>
>> There are/were two "fulls".
>>
>> - assemblies/apache-karaf-full, renamed to apache-karaf. I have no problem with this, I named it -full so we could keep the old apache-karaf assembly around for a short while to make sure I didn't leave out too much.
>>
>> - assemblies/features/full This was a kar that included resources in the full assembly that weren't in (or shouldn't be in) the minimal assembly, and also IIRC pulled in a few bundles needed for the full assembly. I don't think removing this was wise, and the last time I looked there were some missing bundles as a result. However I don't remember the details.
>>
>> thanks
>> david jencks
>>
>> On Nov 28, 2011, at 9:08 AM, Jean-Baptiste Onofré wrote:
>>
>>> Hi David,
>>>
>>> Could you explain ?
>>>
>>> IMO, to provide a "smooth" transition, users should more or less get the same distribution.
>>>
>>> Introducing -full wasn't good for me as people will look for apache-karaf.
>>>
>>> Full is now presents directly in apache-karaf. It's exactly the same.
>>>
>>> Regards
>>> JB
>>>
>>> On 11/28/2011 05:59 PM, David Jencks wrote:
>>>> I still think that removing assemblies/features/full was a mistake (IIRC I -1'ed it with no response) and haven't found where the stuff in it was restored (if anywhere).
>>>>
>>>> david jencks
>>>>
>>>> On Nov 28, 2011, at 6:40 AM, Jamie G. wrote:
>>>>
>>>>> Hi All,
>>>>>
>>>>> I've been looking through our assemblies setup for Karaf trunk and
>>>>> would like to know if we can remove the following folders:
>>>>>
>>>>> http://svn.apache.org/repos/asf/karaf/trunk/assemblies/apache-karaf-full/
>>>>> <-- empty folder, is this a place holder?
>>>>> http://svn.apache.org/repos/asf/karaf/trunk/assemblies/features/full/
>>>>> <-- appears to be unused.
>>>>> http://svn.apache.org/repos/asf/karaf/trunk/assembly/<--- appears to
>>>>> be deprecated.
>>>>>
>>>>> Cheers,
>>>>> Jamie
>>>>
>>>
>>> --
>>> Jean-Baptiste Onofré
>>> jbonofre@apache.org
>>> http://blog.nanthrax.net
>>> Talend - http://www.talend.com
>>
>
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
Re: Assembly/Assemblies clean up
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi David,
yes I saw that. I removed that because I don't see the advantage of the
full kar comparing to the standard one. The standard kar contains the
same thing as the full (as we have currently in the karaf 2.2.x).
Basically, we have three kar:
- framework
- minimal
- standard
Regards
JB
On 11/28/2011 10:31 PM, David Jencks wrote:
> Hi Jean-Baptiste,
>
> There are/were two "fulls".
>
> - assemblies/apache-karaf-full, renamed to apache-karaf. I have no problem with this, I named it -full so we could keep the old apache-karaf assembly around for a short while to make sure I didn't leave out too much.
>
> - assemblies/features/full This was a kar that included resources in the full assembly that weren't in (or shouldn't be in) the minimal assembly, and also IIRC pulled in a few bundles needed for the full assembly. I don't think removing this was wise, and the last time I looked there were some missing bundles as a result. However I don't remember the details.
>
> thanks
> david jencks
>
> On Nov 28, 2011, at 9:08 AM, Jean-Baptiste Onofré wrote:
>
>> Hi David,
>>
>> Could you explain ?
>>
>> IMO, to provide a "smooth" transition, users should more or less get the same distribution.
>>
>> Introducing -full wasn't good for me as people will look for apache-karaf.
>>
>> Full is now presents directly in apache-karaf. It's exactly the same.
>>
>> Regards
>> JB
>>
>> On 11/28/2011 05:59 PM, David Jencks wrote:
>>> I still think that removing assemblies/features/full was a mistake (IIRC I -1'ed it with no response) and haven't found where the stuff in it was restored (if anywhere).
>>>
>>> david jencks
>>>
>>> On Nov 28, 2011, at 6:40 AM, Jamie G. wrote:
>>>
>>>> Hi All,
>>>>
>>>> I've been looking through our assemblies setup for Karaf trunk and
>>>> would like to know if we can remove the following folders:
>>>>
>>>> http://svn.apache.org/repos/asf/karaf/trunk/assemblies/apache-karaf-full/
>>>> <-- empty folder, is this a place holder?
>>>> http://svn.apache.org/repos/asf/karaf/trunk/assemblies/features/full/
>>>> <-- appears to be unused.
>>>> http://svn.apache.org/repos/asf/karaf/trunk/assembly/<--- appears to
>>>> be deprecated.
>>>>
>>>> Cheers,
>>>> Jamie
>>>
>>
>> --
>> Jean-Baptiste Onofré
>> jbonofre@apache.org
>> http://blog.nanthrax.net
>> Talend - http://www.talend.com
>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: Assembly/Assemblies clean up
Posted by David Jencks <da...@yahoo.com>.
Hi Jean-Baptiste,
There are/were two "fulls".
- assemblies/apache-karaf-full, renamed to apache-karaf. I have no problem with this, I named it -full so we could keep the old apache-karaf assembly around for a short while to make sure I didn't leave out too much.
- assemblies/features/full This was a kar that included resources in the full assembly that weren't in (or shouldn't be in) the minimal assembly, and also IIRC pulled in a few bundles needed for the full assembly. I don't think removing this was wise, and the last time I looked there were some missing bundles as a result. However I don't remember the details.
thanks
david jencks
On Nov 28, 2011, at 9:08 AM, Jean-Baptiste Onofré wrote:
> Hi David,
>
> Could you explain ?
>
> IMO, to provide a "smooth" transition, users should more or less get the same distribution.
>
> Introducing -full wasn't good for me as people will look for apache-karaf.
>
> Full is now presents directly in apache-karaf. It's exactly the same.
>
> Regards
> JB
>
> On 11/28/2011 05:59 PM, David Jencks wrote:
>> I still think that removing assemblies/features/full was a mistake (IIRC I -1'ed it with no response) and haven't found where the stuff in it was restored (if anywhere).
>>
>> david jencks
>>
>> On Nov 28, 2011, at 6:40 AM, Jamie G. wrote:
>>
>>> Hi All,
>>>
>>> I've been looking through our assemblies setup for Karaf trunk and
>>> would like to know if we can remove the following folders:
>>>
>>> http://svn.apache.org/repos/asf/karaf/trunk/assemblies/apache-karaf-full/
>>> <-- empty folder, is this a place holder?
>>> http://svn.apache.org/repos/asf/karaf/trunk/assemblies/features/full/
>>> <-- appears to be unused.
>>> http://svn.apache.org/repos/asf/karaf/trunk/assembly/<--- appears to
>>> be deprecated.
>>>
>>> Cheers,
>>> Jamie
>>
>
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
Re: Assembly/Assemblies clean up
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi David,
Could you explain ?
IMO, to provide a "smooth" transition, users should more or less get the
same distribution.
Introducing -full wasn't good for me as people will look for apache-karaf.
Full is now presents directly in apache-karaf. It's exactly the same.
Regards
JB
On 11/28/2011 05:59 PM, David Jencks wrote:
> I still think that removing assemblies/features/full was a mistake (IIRC I -1'ed it with no response) and haven't found where the stuff in it was restored (if anywhere).
>
> david jencks
>
> On Nov 28, 2011, at 6:40 AM, Jamie G. wrote:
>
>> Hi All,
>>
>> I've been looking through our assemblies setup for Karaf trunk and
>> would like to know if we can remove the following folders:
>>
>> http://svn.apache.org/repos/asf/karaf/trunk/assemblies/apache-karaf-full/
>> <-- empty folder, is this a place holder?
>> http://svn.apache.org/repos/asf/karaf/trunk/assemblies/features/full/
>> <-- appears to be unused.
>> http://svn.apache.org/repos/asf/karaf/trunk/assembly/<--- appears to
>> be deprecated.
>>
>> Cheers,
>> Jamie
>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: Assembly/Assemblies clean up
Posted by David Jencks <da...@yahoo.com>.
I still think that removing assemblies/features/full was a mistake (IIRC I -1'ed it with no response) and haven't found where the stuff in it was restored (if anywhere).
david jencks
On Nov 28, 2011, at 6:40 AM, Jamie G. wrote:
> Hi All,
>
> I've been looking through our assemblies setup for Karaf trunk and
> would like to know if we can remove the following folders:
>
> http://svn.apache.org/repos/asf/karaf/trunk/assemblies/apache-karaf-full/
> <-- empty folder, is this a place holder?
> http://svn.apache.org/repos/asf/karaf/trunk/assemblies/features/full/
> <-- appears to be unused.
> http://svn.apache.org/repos/asf/karaf/trunk/assembly/ <--- appears to
> be deprecated.
>
> Cheers,
> Jamie