mesos git commit: Made cleanliness checks in post-reviews.py less strict.

[bb...@apache.org]

Repository: mesos
Updated Branches:
  refs/heads/master 1f12ca5d2 -> 56100adc1


Made cleanliness checks in post-reviews.py less strict.

These checks generate a high amount of unnecessary work for developers
who want to submit part of an ongoing refactoring for review, and
since most developers are advanced git users anyways the amount of
hand-holding seems unnecessary.

Review: https://reviews.apache.org/r/65439/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/56100adc
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/56100adc
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/56100adc

Branch: refs/heads/master
Commit: 56100adc14a8acbcf2ee0aae967f758f592fcd31
Parents: 1f12ca5
Author: Benno Evers <be...@mesosphere.com>
Authored: Mon Feb 5 12:06:09 2018 +0100
Committer: Benjamin Bannier <bb...@apache.org>
Committed: Mon Feb 5 12:19:37 2018 +0100

----------------------------------------------------------------------
 support/post-reviews.py | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/56100adc/support/post-reviews.py
----------------------------------------------------------------------
diff --git a/support/post-reviews.py b/support/post-reviews.py
index 231a3ac..94b4325 100755
--- a/support/post-reviews.py
+++ b/support/post-reviews.py
@@ -108,19 +108,20 @@ def main():
         print 'Please install RBTools before proceeding'
         sys.exit(1)
 
-    # Don't do anything if people have unstaged changes.
+    # Warn if people have unstaged changes.
     diff_stat = execute(['git', 'diff', '--shortstat']).strip()
 
     if diff_stat:
-        print 'Please commit or stash any changes before using post-reviews!'
-        sys.exit(1)
+        print >> sys.stderr, \
+            'WARNING: Worktree contains unstaged changes, continuing anyway.'
 
-    # Don't do anything if people have uncommitted changes.
+    # Warn if people have uncommitted changes.
     diff_stat = execute(['git', 'diff', '--shortstat', '--staged']).strip()
 
     if diff_stat:
-        print 'Please commit staged changes before using post-reviews!'
-        sys.exit(1)
+        print >> sys.stderr, \
+            'WARNING: Worktree contains staged but uncommitted changes, ' \
+            'continuing anyway.'
 
     # Grab a reference to the repo's git directory. Usually this is simply
     # .git in the repo's top level directory. However, when submodules are