You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/18 11:42:47 UTC

[GitHub] [skywalking] hanahmily opened a new issue, #9805: [Feature] Upgrade BanyanDB storage module

hanahmily opened a new issue, #9805:
URL: https://github.com/apache/skywalking/issues/9805

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   Since #9761 merged, we could kick off upgrading the OAP BanyanDB storage module.
   
   The client lib introduces several improvements:
   
   * `exist` endpoints of metadata registry. stream and measure `exist` methods' [return value](https://github.com/apache/skywalking-banyandb-java-client/blob/main/src/main/java/org/apache/skywalking/banyandb/v1/client/metadata/ResourceExist.java#L25
   ) has `hasGroup` which will simplify the interaction of creating groups.
   * `AbstractQuery`'s [`and` method](https://github.com/apache/skywalking-banyandb-java-client/blob/main/README.md#example-of-and) has the same semantic as before. We could leave it alone.
   * `AbstractQuery`'s [`or` method](https://github.com/apache/skywalking-banyandb-java-client/blob/main/README.md#example-of-or) could fit the profile query scenario. 
   * `Property`'s `apply`, `get` and `delete` operations support selecting tags. We could disable a UI template by updating a tag instead of a whole property.
   * Tag specification support the `index_only` flag. We could set trace segment's `searchable` tags to `index_only=true`.
   
   ### Use case
   
   _No response_
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #9805: [Feature] Upgrade BanyanDB storage module

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9805:
URL: https://github.com/apache/skywalking/issues/9805#issuecomment-1282327595

   @wankai123 We could do this with https://github.com/apache/skywalking/issues/9183 together, as it is a TODO from 0.1 integration as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] hanahmily closed issue #9805: [Feature] Upgrade BanyanDB storage module

Posted by GitBox <gi...@apache.org>.
hanahmily closed issue #9805: [Feature] Upgrade BanyanDB storage module
URL: https://github.com/apache/skywalking/issues/9805


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #9805: [Feature] Upgrade BanyanDB storage module

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9805:
URL: https://github.com/apache/skywalking/issues/9805#issuecomment-1282325417

   As @hanahmily requests, I talked with @wankai123 to take cover this after https://github.com/apache/skywalking/issues/9745 is done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org