You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Hudson <gh...@MIT.EDU> on 2005/04/21 02:12:15 UTC
Re: svn commit: r14333 - trunk/subversion/libsvn_fs_fs
On Wed, 2005-04-20 at 16:37, ringstrom@tigris.org wrote:
> - {
> - copyfrom_string = apr_pstrdup (copyfrom_pool, "");
> - }
> + copyfrom_string = NULL;
[...]
> - SVN_ERR (svn_io_file_write_full (file, copyfrom, strlen (copyfrom), NULL,
> - pool));
> + if (copyfrom)
> + {
> + SVN_ERR (svn_io_file_write_full (file, copyfrom, strlen (copyfrom),
> + NULL, pool));
> + }
Why not just set copyfrom_string = "" and avoid the conditional later
on?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r14333 - trunk/subversion/libsvn_fs_fs
Posted by Greg Hudson <gh...@MIT.EDU>.
On Wed, 2005-04-20 at 22:12, Greg Hudson wrote:
> Why not just set copyfrom_string = "" and avoid the conditional later
> on?
Nevermind, I was misreading.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org