[GitHub] rhtyd commented on a change in pull request #1870: CLOUDSTACK-9708: Router deployment failed due to two threads start VR simultaneously.

[gi...@git.apache.org]

rhtyd commented on a change in pull request #1870: CLOUDSTACK-9708: Router deployment failed due to two threads start VR simultaneously.
URL: https://github.com/apache/cloudstack/pull/1870#discussion_r131269487
 
 

 ##########
 File path: engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java
 ##########
 @@ -192,6 +192,18 @@ void init() {
                 JoinBuilder.JoinType.INNER);
         AccountDataCenterVirtualSearch.done();
 
+        SearchBuilder<NicVO> nicSearchByNetwork = _nicDao.createSearchBuilder();
 
 Review comment:
   @nitin-maharana while your fix may be valid, it seems to be breaking some test_nic and test_routers test cases. The issue seems to be another `nicSearch` on line 184 which perhaps is used in most cases. You may remove `nicSearchByNetwork` which is not useful or used at all depending on the original code when UserVmSearch is null or not, when calling the method `listByNetworkIdAndStates`.  Depending on the test results, I may revert your original fix, but kindly re-submit a newer change and I can help run tests for you. Thanks.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services