[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #314: type/select: add select fd_set to types include

[GitBox <gi...@apache.org>]

patacongo commented on a change in pull request #314: type/select: add select fd_set to types include
URL: https://github.com/apache/incubator-nuttx/pull/314#discussion_r381465457
 
 

 ##########
 File path: include/sys/types.h
 ##########
 @@ -301,6 +301,10 @@ typedef CODE int (*main_t)(int argc, FAR char *argv[]);
 
 #endif /* __ASSEMBLY__ */
 
+/* Defines `fd_set' and the FD_* macros for `select'. */
+
+#include <sys/select.h>
+
 
 Review comment:
   I don't believe this is the correct way to handle this.  There is a hieararchy of header files and sys/types.h is probably the lowest level.  It should not be including higher level header files.  This is just incorrect.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services