You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Yunyung (via GitHub)" <gi...@apache.org> on 2025/02/01 17:16:52 UTC
[PR] MINOR: Remove ZooKeeper metrics used for ZooKeeperClient [kafka]
Yunyung opened a new pull request, #18775:
URL: https://github.com/apache/kafka/pull/18775
## Description
Follow-up of #18450.
Remove three metrics used only for ZooKeeper:
- kafka.server:type=SessionExpireListener,name=SessionState
- SessionExpireListener,name=ZooKeeperExpiresPerSec
- SessionExpireListener,name=ZooKeeperDisconnectsPerSec
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Remove the test for ZooKeeper metrics used by ZooKeeperClient [kafka]
Posted by "Yunyung (via GitHub)" <gi...@apache.org>.
Yunyung commented on PR #18775:
URL: https://github.com/apache/kafka/pull/18775#issuecomment-2629139234
The metrics were removed in #18450, but the test and documentation were forgotten.
So this follow-up fixes that.
Also, corrected the wording in this PR title to avoid misunderstanding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Remove the test for ZooKeeper metrics used by ZooKeeperClient [kafka]
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on PR #18775:
URL: https://github.com/apache/kafka/pull/18775#issuecomment-2629144716
Why do the test passing though - that seems odd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Remove the test for ZooKeeper metrics used by ZooKeeperClient [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #18775:
URL: https://github.com/apache/kafka/pull/18775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Remove the test for ZooKeeper metrics used by ZooKeeperClient [kafka]
Posted by "Yunyung (via GitHub)" <gi...@apache.org>.
Yunyung commented on code in PR #18775:
URL: https://github.com/apache/kafka/pull/18775#discussion_r1938989601
##########
docs/zk2kraft.html:
##########
@@ -198,6 +198,9 @@ <h5 class="anchor-heading">Removal metrics</h5>
<li><code>kafka.server:type=DelayedOperationPurgatory,name=PurgatorySize,delayedOperation=topic</code></li>
<li><code>kafka.server:type=DelayedOperationPurgatory,name=NumDelayedOperations,delayedOperation=ElectLeader</code></li>
<li><code>kafka.server:type=DelayedOperationPurgatory,name=NumDelayedOperations,delayedOperation=topic</code></li>
+ <li><code>kafka.server:type=SessionExpireListener,name=SessionState</code></li>
+ <li><code>kafka.server:type=SessionExpireListener,name=ZooKeeperDisconnectsPerSec</code></li>
+ <li><code>kafka.server:type=SessionExpireListener,name=ZooKeeperExpiresPerSec</code></li>
Review Comment:
Thanks:)
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Remove the test for ZooKeeper metrics used by ZooKeeperClient [kafka]
Posted by "Yunyung (via GitHub)" <gi...@apache.org>.
Yunyung commented on PR #18775:
URL: https://github.com/apache/kafka/pull/18775#issuecomment-2629145970
Yeah, here: https://github.com/apache/kafka/commit/434fe7c26e31a6cfeb5e17e83fb52a260eac398e#diff-5bc93ef5ce2e7ef966957f547fe93aa295042c90e92a29d44153e5b434bd952fR251, the change ensures that **KRaft** has no such metrics. So the test always passed before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Remove ZooKeeper metrics used for ZooKeeperClient [kafka]
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on PR #18775:
URL: https://github.com/apache/kafka/pull/18775#issuecomment-2629131104
Looks like we removed the tests, but what about the code that is ensuring the test was passing - it doesn't seem to be removed in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Remove the test for ZooKeeper metrics used by ZooKeeperClient [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #18775:
URL: https://github.com/apache/kafka/pull/18775#discussion_r1938784255
##########
docs/zk2kraft.html:
##########
@@ -198,6 +198,9 @@ <h5 class="anchor-heading">Removal metrics</h5>
<li><code>kafka.server:type=DelayedOperationPurgatory,name=PurgatorySize,delayedOperation=topic</code></li>
<li><code>kafka.server:type=DelayedOperationPurgatory,name=NumDelayedOperations,delayedOperation=ElectLeader</code></li>
<li><code>kafka.server:type=DelayedOperationPurgatory,name=NumDelayedOperations,delayedOperation=topic</code></li>
+ <li><code>kafka.server:type=SessionExpireListener,name=SessionState</code></li>
+ <li><code>kafka.server:type=SessionExpireListener,name=ZooKeeperDisconnectsPerSec</code></li>
+ <li><code>kafka.server:type=SessionExpireListener,name=ZooKeeperExpiresPerSec</code></li>
Review Comment:
Please add following names too.
1. ZooKeeperDisconnectsPerSec
2. ZooKeeperSyncConnectsPerSec
3. ZooKeeperAuthFailuresPerSec
4. ZooKeeperReadOnlyConnectsPerSec
5. ZooKeeperSaslAuthenticationsPerSec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org