You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2022/03/05 18:52:49 UTC

[GitHub] [thrift] emmenlau commented on pull request #2522: THRIFT-5515: Oneway requests can stuck in TNonblockingServer with TSSLSocket.

emmenlau commented on pull request #2522:
URL: https://github.com/apache/thrift/pull/2522#issuecomment-1059814683


   Agree with @RandyAbernethy .
   
   An additional comment: With the loop, the variables `int got, left, sent` and `uint32_t fetch` are not initialized again. I did not double-check that this is fine. @tkovacs-2 , did you check that they are always initialized to useful values in the loop? Otherwise, to be sure, move the declaration and initialization inside the loop?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org