[GitHub] DaanHoogland commented on a change in pull request #2706: packaging: use libuuid x86_64 package for cloudstack-common

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #2706: packaging: use libuuid x86_64 package for cloudstack-common
URL: https://github.com/apache/cloudstack/pull/2706#discussion_r195413127
 
 

 ##########
 File path: tools/appliance/systemvmtemplate/scripts/install_systemvm_packages.sh
 ##########
 @@ -78,12 +78,7 @@ function install_packages() {
   apt-get clean
   apt-get autoclean
 
-  #32 bit architecture support:: not required for 32 bit template
-  if [ "${arch}" != "i386" ]; then
-    dpkg --add-architecture i386
-    apt-get update
-    ${apt_get} install links:i386 libuuid1:i386 libc6:i386
-  fi
+  ${apt_get} install links
 
 Review comment:
   @rhtyd if we have the proper version to rebuild that would be best. In any way teh cloudstack-common package doesn't need it, only the systemvm template.
   we can either
   - ammend the commit that removes the 32 dependencies to allow for glibc and libuuid, or
   - rebuild vhdutil
   What ever is easiest will do for this release, i think

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services