You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2020/09/07 12:45:48 UTC

[GitHub] [parquet-mr] grishaw opened a new pull request #814: PARQUET-1910: Fix broken parquet-cli

grishaw opened a new pull request #814:
URL: https://github.com/apache/parquet-mr/pull/814


   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
     - https://issues.apache.org/jira/browse/PARQUET-XXX
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] grishaw commented on pull request #814: PARQUET-1910: Fix broken parquet-cli

Posted by GitBox <gi...@apache.org>.
grishaw commented on pull request #814:
URL: https://github.com/apache/parquet-mr/pull/814#issuecomment-701940069


   @shangxinli can you please have a look at this? 
   it's related to your recent changes in PARQUET-1872.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] Fokko merged pull request #814: PARQUET-1910: Fix broken parquet-cli

Posted by GitBox <gi...@apache.org>.
Fokko merged pull request #814:
URL: https://github.com/apache/parquet-mr/pull/814


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] shangxinli commented on pull request #814: PARQUET-1910: Fix broken parquet-cli

Posted by GitBox <gi...@apache.org>.
shangxinli commented on pull request #814:
URL: https://github.com/apache/parquet-mr/pull/814#issuecomment-702269518


   Thank you so much for working on this!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] grishaw commented on pull request #814: PARQUET-1910: Fix broken parquet-cli

Posted by GitBox <gi...@apache.org>.
grishaw commented on pull request #814:
URL: https://github.com/apache/parquet-mr/pull/814#issuecomment-702347912


   I'm glad I could be of help : )
   BTW, I am looking for ideas to contribute, if you have anything in mind, please let me know.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org