Re: "svn diff -rN" dereferences a NIL pointer and crashes with "Segmentation fault".

[Greg Hudson <gh...@MIT.EDU>]

On Fri, 2006-02-17 at 13:54 -0800, Garrett Rooney wrote:
> Ok, so here's a "fix" for the bug.  I'm totally not sure this is the
> right thing to do, but due to the incredible suck of nonrecursive
> checkouts, I can't figure out a better way around it.

It seems to me that we should be checking for this case anyway.  Even if
the user reached into the .svn/entries file and carefully corrupted it
to produce this case, we shouldn't be dereferencing a null pointer.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: "svn diff -rN" dereferences a NIL pointer and crashes with "Segmentation fault".

[Garrett Rooney <ro...@electricjellyfish.net>]

On 2/17/06, Greg Hudson <gh...@mit.edu> wrote:
> On Fri, 2006-02-17 at 13:54 -0800, Garrett Rooney wrote:
> > Ok, so here's a "fix" for the bug.  I'm totally not sure this is the
> > right thing to do, but due to the incredible suck of nonrecursive
> > checkouts, I can't figure out a better way around it.
>
> It seems to me that we should be checking for this case anyway.  Even if
> the user reached into the .svn/entries file and carefully corrupted it
> to produce this case, we shouldn't be dereferencing a null pointer.

Makes sense to me.  We really should verify that we don't have that
problem elsewhere.  I suspect we do.

I just dislike the fact that we can't flag "the entry isn't there" as
an error in the case where the user HAS corrupted his entries file,
because it might just be a nonrecursive checkout.  I wonder how many
other places are vulnerable to that particular problem as well.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org