You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by hu...@apache.org on 2022/08/23 23:31:18 UTC

[superset] branch master updated: feat: print comment for chromatic storybook link (#21170)

This is an automated email from the ASF dual-hosted git repository.

hugh pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new cda7d70565 feat: print comment for chromatic storybook link (#21170)
cda7d70565 is described below

commit cda7d705650fd36b7051c1002ab8f152017c9a70
Author: Hugh A. Miles II <hu...@gmail.com>
AuthorDate: Tue Aug 23 19:31:05 2022 -0400

    feat: print comment for chromatic storybook link (#21170)
    
    * Update chromatic.yml
    
    * Update chromatic.yml
    
    * Update chromatic.yml
    
    * Update chromatic.yml
    
    * Update chromatic.yml
    
    * Update chromatic.yml
    
    * working
    
    * plz work
    
    * plzzzzz
    
    * one more time
    
    * one one more time
    
    * this works
    
    * lit
    
    * last one
---
 .github/workflows/chromatic.yml | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/.github/workflows/chromatic.yml b/.github/workflows/chromatic.yml
index c53e34dc8a..66afc24290 100644
--- a/.github/workflows/chromatic.yml
+++ b/.github/workflows/chromatic.yml
@@ -56,6 +56,7 @@ jobs:
         working-directory: superset-frontend
       # 👇 Checks if the branch is not master and runs Chromatic
       - name: Publish to Chromatic
+        id: chromatic-pr
         if: github.ref != 'refs/heads/master'
         uses: chromaui/action@v1
         # Required options for the Chromatic GitHub Action
@@ -67,6 +68,7 @@ jobs:
           exitZeroOnChanges: true # 👈 Option to prevent the workflow from failing
       # 👇 Checks if the branch is master and accepts all changes in Chromatic
       - name: Publish to Chromatic and auto accept changes
+        id: chromatic-master
         if: github.ref == 'refs/heads/master'
         uses: chromaui/action@v1
         # Required options for the Chromatic GitHub Action
@@ -77,3 +79,15 @@ jobs:
           projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
           autoAcceptChanges: true # 👈 Option to accept all changes when merging to master
           exitZeroOnChanges: true # 👈 Option to prevent the workflow from failing
+      - name: Echo Storybook build link
+        if: ${{ success() }}
+        uses: actions/github-script@v6
+        with:
+          github-token: ${{secrets.GITHUB_TOKEN}}
+          script: |
+            github.rest.issues.createComment({
+              issue_number: context.issue.number,
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              body: 'Storybook has completed and can be viewed at ${{ steps.chromatic-pr.outputs.storybookUrl }}'
+            })