You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@bahir.apache.org by sbcd90 <gi...@git.apache.org> on 2016/10/25 18:50:17 UTC

[GitHub] bahir pull request #26: [BAHIR-73][bahir-flink] flink-streaming-akka source ...

GitHub user sbcd90 opened a pull request:

    https://github.com/apache/bahir/pull/26

    [BAHIR-73][bahir-flink] flink-streaming-akka source connector

    This PR is created to propose the idea of having a flink-streaming-akka source connector.
    
    The source connector can be used to receive messages from an Akka feeder or publisher actor & these messages can then be processed using flink streaming.
    
    The source connector has the following features.
    
    It can supports several different message formats like iterable data, bytes array & data with timestamp.
    It can send back acknowledgements to the feeder actor.
    
    Reference to the closed PR in Flink: https://github.com/apache/flink/pull/2644
    
    @rmetzger , kindly review.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sbcd90/bahir flink-akka

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bahir/pull/26.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #26
    
----
commit 1adeb3b18fc7a7cc64d6683eb65ba62ffb7d97ec
Author: Subhobrata Dey <sb...@gmail.com>
Date:   2016-10-25T18:28:26Z

    [BAHIR-73][bahir-flink] flink-streaming-akka source connector

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bahir pull request #26: [BAHIR-73][bahir-flink] flink-streaming-akka source ...

Posted by sbcd90 <gi...@git.apache.org>.
Github user sbcd90 closed the pull request at:

    https://github.com/apache/bahir/pull/26


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bahir issue #26: [BAHIR-73][bahir-flink] flink-streaming-akka source connect...

Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:

    https://github.com/apache/bahir/pull/26
  
    Thanks a lot for opening a pull request here.
    Sadly, you've opened the pull request against the wrong Bahir repository. This one is for Spark extensions in Bahir. Flink extensions go here: https://github.com/apache/bahir-flink
    If its not too much trouble for you, I would appreciate if you could open the pull request against `bahir-flink`. Thank you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---