You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/07/16 22:31:58 UTC

[GitHub] [incubator-gobblin] zxcware commented on a change in pull request #2688: [GOBBLIN-827] Add more events

zxcware commented on a change in pull request #2688: [GOBBLIN-827] Add more events
URL: https://github.com/apache/incubator-gobblin/pull/2688#discussion_r304153493
 
 

 ##########
 File path: gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/event/JobEvent.java
 ##########
 @@ -27,7 +27,7 @@
  */
 public class JobEvent {
 
-  public static final String JOB_STATE = "JobStateEvent";
+  public static final String JOB_STATE = "JobStateEvent"; // TODO: Migrate to JobStateEventBuilder
 
 Review comment:
   It is used to emit MRJob status in this pr.  Migrating gobblin job status to use it is a separate task.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services